[Patch] Blame: Fix incorrect parent windows for the progress dialog
7 views
Skip to first unread message
Denis Kovalchuk
unread,
Dec 15, 2025, 4:59:12 AM (yesterday) Dec 15
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to TortoiseSVN-dev
Hi!
I've noticed that the parent window for the "CProgressDlg" [1] may be set incorrectly when using the Blame command.
The "Blame" [2] class is used in the following cases: 1. The "Blame..." command in the Windows Explorer context menu. 2. The "Blame..." command in the "Log Messages" dialog context menu. 3. The "Blame..." command in the "Repository Browser" dialog context menu.
In all these cases, the "Blame" class uses GetExplorerHwnd() [3] as the parent window for the progress dialog. This is incorrect for cases 2 and 3, because the parent windows are the dialogs.
For comparison, the "Show changes" command behaves correctly: 1. It uses GetExplorerHwnd() [4] in the case of the Windows Explorer context menu. 2. It uses the dialog's m_hWnd [5] in the case of the "Log Messages" context menu.
For example, this causes some problems with disabling the parent window, when TortoiseProc.exe is called with the /hwnd parameter.