[PATCH] Fix: TortoiseSVN (trunk) displays "fetching text bases" notifications incorrectly

20 views
Skip to first unread message

Denis Kovalchuk

unread,
Aug 15, 2023, 11:00:49 AM8/15/23
to TortoiseSVN-dev
Hi!

I've noticed that TortoiseSVN (trunk) displays "fetching text bases"
notifications incorrectly when working with a working copy that does not store
local copies of pristine contents. See incorrect-notifications.png in the
attachments.

Steps to reproduce:
1. Open TortoiseSVN Checkout dialog box.
2. Uncheck the "Store pristine copies in working copy" checkbox.
3. Check out a working copy.
4. Delete any files using "TortoiseSVN > Delete".
5. Revert local changes using "TortoiseSVN > Revert".

This happens because TortoiseSVN builds with Subversion 1.15-dev, but does not
handle the new hydration notifications (svn_wc_notify_hydrating_start,
svn_wc_notify_hydrating_file, svn_wc_notify_hydrating_end) added in r1905955 [1].

svn.exe currently handles these notifications in the following way, where each
dot indicates one fetched file:

"Fetching text bases .........done."

I've attached a patch that adds handling of these notifications in a similar
manner (see fetching-text-bases.gif images in the attachments):

"Fetching text bases | N files"

[1] https://svn.apache.org/viewvc?view=revision&revision=1905955

Best Regards,
Denis Kovalchuk
fetching-text-bases-revert-command.png
fetching-text-bases.gif
incorrect-notifications.png
fetching-text-bases-update-command.png
fix-incorrect-notifications-v1.patch.txt

Stefan

unread,
Aug 15, 2023, 3:54:59 PM8/15/23
to TortoiseSVN-dev
Thanks for the patch!

After a first look I think this is great. I will do some testing first, but I think I'll commit your patch soon.

Stefan

Stefan

unread,
Aug 16, 2023, 2:31:50 PM8/16/23
to TortoiseSVN-dev
committed your patch in r29607.
Reply all
Reply to author
Forward
0 new messages