[PATCH] Fix for duplicated externals in Copy dialog

23 views
Skip to first unread message

Patrick Steinhardt

unread,
May 14, 2018, 6:03:10 AM5/14/18
to tortois...@googlegroups.com
Hi,

When the registry key "HKCU\Software\TortoiseSVN\CommitReopen" is
set to "1", then the Copy dialog will reopen in case the commit
failed. If this happens and the repository contains externals,
then the list of externals will display all externals multiple
times, as the externals vector is not getting cleared before it's
being repopulated.

The attached patch fixes that by first clearing the externals
vector.


The issue was found in 1.9.7, but applies to 1.10.0 and trunk, as
well. It would be nice if it was applied to all three branches.

Thanks and regards
Patrick
copy-duplicated-exts.patch
signature.asc

Stefan

unread,
May 14, 2018, 3:38:12 PM5/14/18
to TortoiseSVN-dev
Thanks for the patch!
Committed in r28219

Stefan

Patrick Steinhardt

unread,
May 15, 2018, 2:00:10 AM5/15/18
to TortoiseSVN-dev on behalf of Stefan
Thanks Stefan. In case there are plans for a 1.9.8 release, would
it be possible to merge this patch to the 1.9.x branch, as well?

Thanks and regards
Patrick
signature.asc

Stefan

unread,
May 15, 2018, 1:33:42 PM5/15/18
to TortoiseSVN-dev
Right now there's no plan to make any releases for the 1.9.x branch anymore.

Stefan
Reply all
Reply to author
Forward
0 new messages