Display issues in log dialog with 1.10.1

72 views
Skip to first unread message

sbrueg...@gmx.net

unread,
Jul 26, 2018, 5:00:41 AM7/26/18
to TortoiseSVN-dev
Hi,

since installing 1.10.1 I see quite massive display issues in the log messages dialog and the Project Monitor.

If the log messages dialog is minimized and restored and I try to scroll the list of log messages, the list overwrites the middle panel where the log message text is supposed to be and sometimes even the path list at the bottom.

In the Project Monitor this happens as soon as the Monitor Windows is closed and reopened via the tray icon.

Sometimes the scroll handle of the log messages list is missing, escpecially when the log message dialog is maximized.

It's not 100% reproducible as described, but I see that very often and on different machines.

Kind regards

Stefan

unread,
Jul 26, 2018, 5:09:19 PM7/26/18
to TortoiseSVN-dev
I don't see that problem here on my machines (one at home, three in the office).
Can you post a screenshot?

Stefan

"Sven Brüggemann"

unread,
Jul 27, 2018, 2:41:15 AM7/27/18
to tortois...@googlegroups.com
 
Hello,
I hope they get attached this time...
 
Kind regards
 
 
LogMessage.png
ProjectMonitor.png

sbrueg...@gmx.net

unread,
Jul 27, 2018, 7:54:47 AM7/27/18
to TortoiseSVN-dev
Hello,

two colleagues were also able to easily reproduce this problem. 1.9.6 and 1.10.0 work fine, 1.10.1 shows this behaviour.

Tested on German Win 8.1 and Win 10 with 64Bit TSVN.

It seems to be related to minimize/restore-cycles. Losing focus or overlapping the dialog with other windows does not trigger the display issues.

BTW: The path list at the bottom is also affected if there are enough paths in it to scroll them.

Kind regards

Stefan

unread,
Jul 27, 2018, 3:57:07 PM7/27/18
to TortoiseSVN-dev
I think I got the problem to show on my machine. But I don't get it the same way as in the posted screenshots. At least not exactly the same.
Have to do some more investigating - found a problem which was there for a long time as well.
I'll report back when I have a fix committed. Maybe tomorrow...

Stefan

Stefan

unread,
Jul 28, 2018, 8:31:15 AM7/28/18
to TortoiseSVN-dev
please try a nightly build (>= rev 28324) and report back if the issue is fixed for you.
I've committed a fix for the issues I could reproduce on my machine which I hope also fixes your issues.


Stefan

sbrueg...@gmx.net

unread,
Jul 30, 2018, 3:27:08 AM7/30/18
to TortoiseSVN-dev
Hello,

the scrolling issue is fixed with r28324, thanks.

However, the splitter positions are not restored anymore. If I adjust all three panels to equal size, minimize and restore the log messages dialog or close and reopen it, the panels change size, usually with a very small middle panel.

If the dialog is quite narrow, the entries and labels in the filter area overlap each other after a minimize-restore cycle.

I also noticed some hardly reproducible display issues when hovering the mouse over the list of revisions in the top panel.

Kind regards

Stefan

unread,
Jul 30, 2018, 3:26:34 PM7/30/18
to TortoiseSVN-dev
Thanks for testing and reporting back.
What you mentioned about the splitter positions not being saved and minimizing/maximizing the dialog helped me to find some other issues.
I've fixed those in r28327.

So if you could test the next nightly build as well, that would help me a lot.

Stefan

sbrueg...@gmx.net

unread,
Jul 31, 2018, 3:08:40 AM7/31/18
to TortoiseSVN-dev
The display issues are all fixed now, including the overlapping filter fields. Splitter positions are restored as expected. Many thanks.

BTW: The link "Release Candidates" on https://tortoisesvn.net/downloads.html still points to the 1.9-branch. You might want to change that to 1.10.

Kind regards

Stefan

unread,
Jul 31, 2018, 1:22:41 PM7/31/18
to TortoiseSVN-dev


On Tuesday, July 31, 2018 at 9:08:40 AM UTC+2, (unknown) wrote:
The display issues are all fixed now, including the overlapping filter fields. Splitter positions are restored as expected. Many thanks.

Thanks a lot for testing!
 

BTW: The link "Release Candidates" on https://tortoisesvn.net/downloads.html still points to the 1.9-branch. You might want to change that to 1.10.


Thanks for the report. I've committed the change, but it might take a while until the website gets updated as well.

Stefan
Reply all
Reply to author
Forward
0 new messages