Project Monitor, assert if logcache disabled and monitoring an unaccessible url

[Daniel Sahlberg]

  Hi,

I'm getting an assert in CCacheLogQuery::GetCache(). I believe it is reproducible:

- Disable log caching in the TortoiseSVN settings

- Setup two projects to monitor, one functional (eg https://svn.osdn.net/svnroot/tortoisesvn/) and one where you don't have access (I'm using https://svn.apache.org/repos/private/pmc/)

- Start Project Monitor

- Click on the functional project, then on the non-functional project, then on the functional project again. The assert in GetCache() triggers.

I don't fully understand how the logcache works, but it seems the cache variable is not initialized with log caching turned off (which sounds reasonable!), however there should be no calls to the logcache objects. Or they should handle a NULL cache properly.

Anyone?

Kind regards,

Daniel

[Stefan]

I don't fully understand how the logcache works, but it seems the cache variable is not initialized with log caching turned off (which sounds reasonable!), however there should be no calls to the logcache objects. Or they should handle a NULL cache properly.

The log cache is always used, even if disabled. But if disabled, the data in the cache is not saved to disk or loaded from it. Then the 'cache' just holds all the log info in memory.

the assertion is fixed in r29488

[Daniel Sahlberg]

Thanks both for the fix and the explaination. Seems to work now =) 

/Daniel