TortoisePLink working in TortoiseSVN 1.14.7, but not in 1.14.8

[Juan Gabriel Covas Egea]

Upgrading TortoseSVN to version 1.14.8 started to show "svn: E170013: Unable to connect to a repository at URL 'svn+xxx://host/repo/project/trunk'

Being "xxx" a protocol defined in [tunnels] at config file, diagnosed the connection and was OK, tried "PLink.exe" instead of TortoisePLink.exe and connection was OK.

So I copied old TortoisePLink.exe from 1.14.7 to "bin" and it works.

A difference I can see:

TortoisePLink.exe from 1.14.7 if called with "-V" argument, shows version in dialog.

TortoisePLink.exe from 1.14.8 if called with "-V" argument, displays nothing.

Best regards,

Juan Gabriel Covas

[Daniel Sahlberg]

Thanks for the report. I see the same behaviour, although I don't have time to fully dig into it now.

Checking the code though, there are a few things catching my eye:

* cmdline_process_param is declared in putty.h having four parameters

* It is defined in cmdline.c having five parameters

* The TortoisePlink.patch is adding the extra parameter to the definition and to all call sites, but not to the header file

* The code in r29707 seems to remove the extra parameter in plink.c to "fix build for latest VS version" (copied from the commit message)

I'm suspecting r29707 to be the cause of this issue.

Kind regards,

Daniel

[Daniel Sahlberg]

There was a fix in r29732. Unfortunately I don't have a svn+ssh:// repository to test. Would you consider downloading a nightly build (https://nightlybuilds.tortoisesvn.net/latest/x64/full/) to test if this solves your problem?

The nightly builds are not digitally signed so the Windows 11 context menu will not work (TortoiseSVN will still be available by selecting Show more options) so you might want to take TortoisePLink.exe from the nightly build and install on top of 1.14.8 if testing is successful.

Kind regards,

Daniel

[Juan Gabriel Covas Egea]

Sure thing, thanks! I can confirm it works.

Took the file TortoisePLink.exe from TortoiseSVN-1.14.99.29733-dev-x64-svn-1.14.dev.msi

and installed it on top of 1.14.8

Cheers,

Juan Gabriel