Commit warning about a tag

46 views
Skip to first unread message

Graham Bloice

unread,
Apr 10, 2013, 12:19:20 PM4/10/13
to d...@tortoisesvn.tigris.org
After updating to 1.7.12 and attempting to commit I got a warning dialog that the commit path appears to be a tag, and giving options to commit or cancel.

The repo path was a long one but wasn't a tag branch, e.g. "svn://repo/product/changes/name of change branch".

The commit did include a file with a .tag suffix though.

Clicking the commit option in the warning dialog allowed the commit to proceed normally.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3052959

To unsubscribe from this discussion, e-mail: [dev-uns...@tortoisesvn.tigris.org].

Stefan Küng

unread,
Apr 12, 2013, 8:54:26 AM4/12/13
to d...@tortoisesvn.tigris.org
On 10.04.2013 18:19, Graham Bloice wrote:
> After updating to 1.7.12 and attempting to commit I got a warning
> dialog that the commit path appears to be a tag, and giving options
> to commit or cancel.

Yup, the message tells you that it "appears to be" a tag. Since SVN
doesn't have a clear 'tag' but allows you to specify that yourself, that
check can never ever be 100% accurate. And that's why the message tells
you that it appears to be so.

> The repo path was a long one but wasn't a tag branch, e.g.
> "svn://repo/product/changes/name of change branch".
>
> The commit did include a file with a .tag suffix though.
>
> Clicking the commit option in the warning dialog allowed the commit
> to proceed normally.

Also true and intentional.

Stefan

--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest interface to (Sub)version control
/_/ \_\ http://tortoisesvn.net

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3053145

Graham Bloice

unread,
Apr 13, 2013, 10:11:13 AM4/13/13
to d...@tortoisesvn.tigris.org
This will (initially) cause confusion for our users as we have lots of files with a .tag suffix. The permissions on our repo are such that ordinary users can never commit to the tags branches anyway.

Is there an option to turn off the erroneous (for us) message anywhere? I had a look in settings but nothing jumped out.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3053241

Simon Large

unread,
Apr 13, 2013, 11:02:14 AM4/13/13
to d...@tortoisesvn.tigris.org
On 12 April 2013 13:54, Stefan Küng <torto...@gmail.com> wrote:
> On 10.04.2013 18:19, Graham Bloice wrote:
>> After updating to 1.7.12 and attempting to commit I got a warning
>> dialog that the commit path appears to be a tag, and giving options
>> to commit or cancel.
>
> Yup, the message tells you that it "appears to be" a tag. Since SVN
> doesn't have a clear 'tag' but allows you to specify that yourself, that
> check can never ever be 100% accurate. And that's why the message tells
> you that it appears to be so.

Is it not enough to check that directory name does not contain 'tag'.
Otherwise anyone who uses .tag files is going to hit this on every
commit.

>> The repo path was a long one but wasn't a tag branch, e.g.
>> "svn://repo/product/changes/name of change branch".
>>
>> The commit did include a file with a .tag suffix though.
>>
>> Clicking the commit option in the warning dialog allowed the commit
>> to proceed normally.
>
> Also true and intentional.

Simon

--
: ___
: oo // \\ "De Chelonian Mobile"
: (_,\/ \_/ \ TortoiseSVN
: \ \_/_\_/> The coolest Interface to (Sub)Version Control
: /_/ \_\ http://tortoisesvn.net

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3053242

Stefan Küng

unread,
Apr 14, 2013, 12:58:08 PM4/14/13
to d...@tortoisesvn.tigris.org
On 13.04.2013 17:02, Simon Large wrote:
> On 12 April 2013 13:54, Stefan Küng <torto...@gmail.com> wrote:
>> On 10.04.2013 18:19, Graham Bloice wrote:
>>> After updating to 1.7.12 and attempting to commit I got a warning
>>> dialog that the commit path appears to be a tag, and giving options
>>> to commit or cancel.
>>
>> Yup, the message tells you that it "appears to be" a tag. Since SVN
>> doesn't have a clear 'tag' but allows you to specify that yourself, that
>> check can never ever be 100% accurate. And that's why the message tells
>> you that it appears to be so.
>
> Is it not enough to check that directory name does not contain 'tag'.
> Otherwise anyone who uses .tag files is going to hit this on every
> commit.

Settings->Revision Graph->Classification Patterns
if you remove the trunk/branches/tags strings there, the check will be
skipped.

And it really only checks for /tags/, not for .tags or something else.

Stefan

--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest interface to (Sub)version control
/_/ \_\ http://tortoisesvn.net

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3053276
Reply all
Reply to author
Forward
0 new messages