[PATCH] Empty message box when applying a patch that does not affect any files
32 views
Skip to first unread message
Denis Kovalchuk
unread,
Feb 9, 2022, 5:57:47 PM2/9/22
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Sign in to report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to TortoiseSVN-dev
Hello!
Steps to reproduce: 1. Download the empty.patch from attachments. 2. Open TortoiseMerge.exe. 3. Enter the path to the empty.patch. 4. Enter the path to any working copy. 5. Click "OK".
The same behavior if you try to apply any file that is not a patch. It looks like if the applied file does not affect any files, then it is considered an error (see line 782 in TortoiseMerge/MainFrm.cpp [1]). But SVNPatch::Init() [2] does not set an error message in this case.
What do you think if this case is not treated as an error? I've attached a patch.