[PATCH] ShellCache: Fix IsContextPathAllowed() to use latest configuration

12 views
Skip to first unread message

Benjamin Robin

unread,
Apr 10, 2021, 6:40:17 AMApr 10
to TortoiseSVN-dev
IsContextPathAllowed() calls ExcludeContextValid() to update excontextvector.
But ExcludeContextValid() almost never do it, since it was checking for
the return of RefreshIfNeeded(). The registry event my have been consumed by
another ShellCache function just before calling ExcludeContextValid().

When starting (When explorer is launched), excludecontextstr and excontextvector
are empty. And they will stay empty forever since the registry is not going to
change (require a setting change I guess).

So remove the return check to RefreshIfNeeded(), which is not needed, there is
already a check to prevent to compute every time excontextvector, .
Also do not take the lock, it was already taken by the caller.

See also https://github.com/TortoiseGit/TortoiseGit/pull/238
ShellCache-ExcludeContextValid.c
ShellCache.patch

Stefan

unread,
Apr 10, 2021, 12:28:25 PMApr 10
to TortoiseSVN-dev
thanks!
Committed in r29104

Reply all
Reply to author
Forward
0 new messages