ignore tools.zip in tortoisesvn/trunk

19 views
Skip to first unread message

Daniel Sahlberg

unread,
May 30, 2022, 2:59:31 PM5/30/22
to TortoiseSVN-dev
Hi,
nant init seems to leave the tools.zip in the wc. Any particular reason why it is not in svn:ignore? Otherwise I'll add it there to remove at least one small thing from "Check for modifications".
/Daniel

Stefan

unread,
May 30, 2022, 3:04:58 PM5/30/22
to TortoiseSVN-dev
you can of course add it to svn:ignore.
But since it's not used after the download/unzip anymore, I usually just delete it.

Daniel Sahlberg

unread,
May 30, 2022, 4:44:31 PM5/30/22
to TortoiseSVN-dev
måndag 30 maj 2022 kl. 21:04:58 UTC+2 skrev Stefan:
you can of course add it to svn:ignore.
But since it's not used after the download/unzip anymore, I usually just delete it.

I'm lazy enough to forget about such things.

Better to have the build script delete the file?

[[[
Index: default.build
===================================================================
--- default.build    (revision 29403)
+++ default.build    (working copy)
@@ -545,6 +545,7 @@
       <get src="https://osdn.net/frs/redir.php?m=acc&amp;f=%2Fstorage%2Fg%2Ft%2Fto%2Ftortoisesvn%2Fbuild+tools%2FTools-1.8.0.zip" dest="tools.zip" />
       <unzip zipfile="tools.zip" />
       <touch file="Tools\ver-1.8.0" />
+      <delete file="tools.zip" />
     </if>
   </target>
]]]

Stefan

unread,
May 31, 2022, 11:33:46 AM5/31/22
to TortoiseSVN-dev
I guess that's one solution. When I first created that script I though maybe users would like to keep the file.
But maybe it's really better to just delete it - users can always zip the unzipped folder again...

Daniel Sahlberg

unread,
Jun 4, 2022, 12:10:17 PM6/4/22
to TortoiseSVN-dev
tisdag 31 maj 2022 kl. 17:33:46 UTC+2 skrev Stefan:
I guess that's one solution. When I first created that script I though maybe users would like to keep the file.
But maybe it's really better to just delete it - users can always zip the unzipped folder again...

r29405. Let's see how that works out. 
Reply all
Reply to author
Forward
0 new messages