Data anomaly

[Garry Petrie]

Where are the "unset shot extends?"

Turns out to be a hidden shot, 41 to 62. But the normal shot list doesn't have it until "repeated legs" is selected. 

Then you see 41 to 62 created a loop. The user manually added 61 to 62, possible explanation?

[Marco Corvi]

this is an interesting issue:

how should the app handle consecutive shots that are within tolerance (ie, "close shots") ?

when data come in, downloaded from the device the shots are considered as "secondary leg shots".

this allows the app to identify legs and separate them from splays.

so far, so good.

what should the app do when the user changes the station names ?

right now the app takes the station names entered by the user, 

the shots in the example are still "close shots" and if the user flags

not to display them, they are not displayed.

should the app display the second shot if it is a leg ?

and what should it do if the shot is a splay ?

and what should the app do if  the second shot is a leg with the same stations as the first ?

and what should it do in any other possible situation that might occur ?

[Balambér Hakapesz]

I think the current solution is good. If the user changes the numbering, that has to be accepted.

I don't understand the current example.

B.

--
You received this message because you are subscribed to the Google Groups "TopoDroid" group.
To unsubscribe from this group and stop receiving emails from it, send an email to topodroid+...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/topodroid/0aa5bfec-d540-45a8-aa05-d399cfb297can%40googlegroups.com.

[Marco Corvi]

let me try to explain my understanding of the problem and see if there really is an issue or the current implenentation is fine.

topodroid flag shot as NORMAL (leg, splay, blank) or EXTRA (repeated leg shot).

there are other flags but these come with the download packet.

suppose the downloaded data have a leg shot with two close shot immediately following it. say

1 A B 10 0 0

2 - - 10 0 0

3 - - 10 0 0

where 1,2,3 are the shot indices, A and B the stations, and the rest the shot data.

shot 1 is NORMAL, shots 2 and 3 are EXTRA.

is the user edit shot 2 and set stations A C 

shot 2 becomes a LEG, and it is shown as such when the edit dialog returns to the shot list (because the list display is set to show repeated shots).

however when the user change the list display to hide repeated shots, shot 2 is not shown.

shot 2 is a leg (it has stations FROM and TO) and it is properly handled in the data reduction, when a sketch is opened.

however, since the stations were set by the user and not by the program, the shot does not have the "extend" specified (unless the user did it). therefore the data reduction can warn that there is a leg without "extend" and the extended profile is partial (except is a corner case, but this is not important).

to come back to the issue,

[1] what should the program do in order to provide a proper display-feedback to the user?

[2] what if the user edit shot 2 and sets stations to A B ?

does the shot become a sibling of shot 1, or should the program revert it to a repeated leg shot ?

the effect on the data reduction is negligeable in practice.

[3] what should happen to shot 3 if the user set shot 2 stations to B -, ie, a splay at station B ?

To view this discussion visit https://groups.google.com/d/msgid/topodroid/CAPq666Mfo6SmbuxXSpwN9RVp%3DyLb1M%2B4q7%3Dm7RW%3DnG-Ojz%3DBsw%40mail.gmail.com.

[Balambér Hakapesz]

A prompt and a request for confirmation are always required when editing a repeated shot. 

[1] what should the program do in order to provide a proper display-feedback to the user?

More precise indication of the error location (e.g., measurement line number).

Link to the manual page containing the causes of the error and their solutions.

[2] what if the user edit shot 2 and sets stations to A B ?

does the shot become a sibling of shot 1, or should the program revert it to a repeated leg shot ?

the effect on the data reduction is negligeable in practice.

sibling and messages

[3] what should happen to shot 3 if the user set shot 2 stations to B -, ie, a splay at station B ?

Nothing; keep the  repeated  of 2 lines. The user's intent—they simply need to be warned.

To view this discussion visit https://groups.google.com/d/msgid/topodroid/CAJiQYo15cF%2B5%2BBnit8TQmPuH2ACAur4sQtLLv0b48EPDWAr89A%40mail.gmail.com.

[Garry Petrie]

I've attached the survey, I am not the author. I think the user didn't understand he created a station pair, a shot and it appears accidental. I think once does this, intentional or not, must be made visible. 

To view this discussion visit https://groups.google.com/d/msgid/topodroid/CAPq666MRALTpG%3Dd9r31hXKv2Sdkj2ymkf%2B%3DMq6G3ZwrMFfwUFw%40mail.gmail.com.

[Marco Corvi]

i agree with providing the user with proper feedback.

i would refrain from unnecessary confirm-dialogs: they are a nuisance.

v. 6.5.23 has some fix, but it is not definitive;

i expect that the splay case is still not handled properly.

To view this discussion visit https://groups.google.com/d/msgid/topodroid/CANbKGSNJS6z1jMtomdHExLuxqowMd%3DyuF8qGpmWgE0QW5ST2kA%40mail.gmail.com.