libechonest 2.1

[domme]

Hey,

while packaging Tomahawk 0.7.0 for openSUSE I noticed that libechonest 2.0.3 hadn't bumped the soversion although API was added.
There was no ABI break, so old binaries continue to work but Tomahawk didn't automatically require the new version which it was compiled/linked against.

Maybe this is important for you too..

I made Leo release a new version called 2.1 with the soversion bumped, it's basically the same as 2.0.3.

The only other difference I can think of right now is a fix for the export macro on windows, which you need to compile Tomahawk master for windows..



BR,
Domme

[domme]

You can get it here btw: http://files.lfranchi.com/libechonest-2.1.0.tar.bz2

[Rex Dieter]

On 05/22/2013 01:48 PM, domme wrote:
> Hey,
>
> while packaging Tomahawk 0.7.0 for openSUSE I noticed that libechonest
> 2.0.3 hadn't bumped the soversion although API was added.
> There was no ABI break, so old binaries continue to work but Tomahawk
> didn't automatically require the new version which it was
> compiled/linked against.
>
> Maybe this is important for you too..
>
> I made Leo release a new version called 2.1 with the soversion bumped,
> it's basically the same as 2.0.3.

As far as I can tell,
http://files.lfranchi.com/libechonest-2.1.0.tar.bz2
doesn't bump the soversion, still at libechonest.so.2 , same as was
2.0.3 release.

???

-- rex

[Dominik Schmidt]

Am 22.05.2013 21:07, schrieb Rex Dieter:> As far as I can tell,

> http://files.lfranchi.com/libechonest-2.1.0.tar.bz2
> doesn't bump the soversion, still at libechonest.so.2 , same as was
> 2.0.3 release.
>
> ???
>
> -- rex
>

Feedback, yay!


The soversion should be at 2.1 and on openSUSE that was enough to bump
the requirement. Would Fedora need an soversion change to 3?

This is what I see when installing:
-- Installing: test/home/domme/dev/installs/lib64/libechonest.so.2.1.0
-- Installing: test/home/domme/dev/installs/lib64/libechonest.so.2.1
-- Installing: test/home/domme/dev/installs/lib64/libechonest.so

I'd find it weird to somehow depend on version 2


Best regards,
Domme

[Rex Dieter]

On 05/22/2013 02:12 PM, Dominik Schmidt wrote:
> Am 22.05.2013 21:07, schrieb Rex Dieter:> As far as I can tell,
> > http://files.lfranchi.com/libechonest-2.1.0.tar.bz2
> > doesn't bump the soversion, still at libechonest.so.2 , same as was
> > 2.0.3 release.

> The soversion should be at 2.1 and on openSUSE that was enough to bump
> the requirement. Would Fedora need an soversion change to 3?
>
> This is what I see when installing:
> -- Installing: test/home/domme/dev/installs/lib64/libechonest.so.2.1.0
> -- Installing: test/home/domme/dev/installs/lib64/libechonest.so.2.1
> -- Installing: test/home/domme/dev/installs/lib64/libechonest.so
>
> I'd find it weird to somehow depend on version 2

Oh, indeed. My packaging assumed integer soversion, I used glob:
%{_libdir}/libechonest.so.2*

thanks for whacking me with a cluestick.

-- rex