Archaius v2

37 views
Skip to first unread message

Pete Hannam

unread,
May 31, 2016, 8:29:04 AM5/31/16
to togglz-dev
Hi,

The Archaius module doesn't work with Archaius v2 (the devs state that it's not backwards compatible in the wiki and there's an explicit cast in the current code that precludes using the provided Archaius v1 -> v2 bridge). The changes to get it working are trivial, but given the lack of backwards support it feels like it should be a separate module.

I tried to raise a pull request as per the contributors guide, but didn't have push rights.

Thanks,
Pete

Christian Kaltepoth

unread,
Jun 1, 2016, 4:30:20 AM6/1/16
to toggl...@googlegroups.com, Richard Steele
Hey Pete,

hmm. So if Archaius v2 isn't backwards compatible with v1, I think a separate module would make sense. "togglz-archaius2".

@Richard: Any thoughts on this?

Pull requests should work fine even without having any direct permissions on the repository. Just clone the repo to your own account, start working on a branch, push that branch to your clone and then start the pull request.

Christian

Steele, Richard

unread,
Jun 4, 2016, 2:29:03 PM6/4/16
to Christian Kaltepoth, toggl...@googlegroups.com
Agree completely.  We haven't been able to upgrade to v2 yet because (if I recall correctly) it depends on >= Java 7, which we'll be able to do Real Soon Now.

Christian Kaltepoth

unread,
Jun 7, 2016, 6:05:36 AM6/7/16
to toggl...@googlegroups.com
@Richard:
Thanks a lot for sharing you thoughts on this. So it looks like a separate module definitely makes sense.

@Pete
Thanks for offering your help on this. I think having a "archaius2" module would be awesome. So it looks like you already read the contributions wiki page. So I think you have everything you need to get started. Feel free to contact me if you have any questions.

Christian

Reply all
Reply to author
Forward
0 new messages