Shouldn't spring boot starter autoconfiguration populate HttpServletRequestHolder?

[Trygve Aasjord]

I am using the spring boot starter and added a custom strategy to check HTTP header parameter for activation (didn't immediately find one out-of-the-box. But I noticed that HttpServletRequestHolder does not contain any request object, so I rolled my own filter to populate it. But shouldn't autoconfiguration do this by default, like the vanilla TogglzFilter does? I have not tested but I assume the other default servlet based strategies maybe doesn't work without it either. 

[Christian Kaltepoth]

I'm not so familiar with Boot, but doesn't Spring Boot also work without a Servlet container? In this case it may be problematic to initialize the holder. 

Christian 

[Trygve Aasjord]

The togglz spring-boot-starter auto configuration would add filter/interceptor to initialize holder only if in a web environment. I actually found that it registers SpringSecurityUserProvider if spring-security is on the classpath, so I guess username strategy is taken care of, but I think that the ClientIp and ServerName strategies cannot work without it.

[Christian Kaltepoth]

Could you perhaps file an issue for this?

--

Christian Kaltepoth

Blog: http://blog.kaltepoth.de/

Twitter: http://twitter.com/chkal

GitHub: https://github.com/chkal

[Trygve Aasjord]

Yes, sure. I just wanted to check first whether this was intentional or if I have missed something. 

[Christian Kaltepoth]

I don't think that it is intentional. But we can discuss this with Marcel in the issue you create. Maybe we are missing something. Marcel is the expert for the Spring Boot integration. :-)