[PATCH] Fix warnings

10 views
Skip to first unread message

Thomas Adam

unread,
Apr 5, 2020, 6:57:09 PM4/5/20
to tmux-...@googlegroups.com, Thomas Adam
---
cmd-new-session.c | 2 +-
cmd-run-shell.c | 2 +-
window-copy.c | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/cmd-new-session.c b/cmd-new-session.c
index c76b564e..a2839e7b 100644
--- a/cmd-new-session.c
+++ b/cmd-new-session.c
@@ -76,7 +76,7 @@ cmd_new_session_exec(struct cmd *self, struct cmdq_item *item)
const char *errstr, *template, *group, *prefix, *tmp;
char *cause, *cwd = NULL, *cp, *newname = NULL;
int detached, already_attached, is_control = 0;
- u_int sx, sy, dsx, dsy;
+ u_int sx, sy, dsx = 80, dsy = 24;
struct spawn_context sc;
enum cmd_retval retval;
struct cmd_find_state fs;
diff --git a/cmd-run-shell.c b/cmd-run-shell.c
index a57beb83..2fe3965a 100644
--- a/cmd-run-shell.c
+++ b/cmd-run-shell.c
@@ -163,7 +163,7 @@ cmd_run_shell_callback(struct job *job)
struct cmdq_item *item = cdata->item;
char *cmd = cdata->cmd, *msg = NULL, *line;
size_t size;
- int retcode, status;
+ int retcode = -1, status;

do {
if ((line = evbuffer_readline(event->input)) != NULL) {
diff --git a/window-copy.c b/window-copy.c
index 1a558915..232863d8 100644
--- a/window-copy.c
+++ b/window-copy.c
@@ -2662,7 +2662,7 @@ window_copy_search_jump(struct window_mode_entry *wme, struct grid *gd,
{
u_int i, px, sx, ssize = 1;
int found = 0, cflags = REG_EXTENDED;
- char *sbuf;
+ char *sbuf = NULL;
regex_t reg;

if (regex) {
@@ -2792,7 +2792,7 @@ window_copy_search_marks(struct window_mode_entry *wme, struct screen *ssp,
int cflags = REG_EXTENDED;
u_int px, py, b, nfound = 0, width;
u_int ssize = 1;
- char *sbuf;
+ char *sbuf = NULL;
regex_t reg;
time_t tstart, t;

--
2.26.0

Nicholas Marriott

unread,
Apr 6, 2020, 1:36:56 AM4/6/20
to Thomas Adam, tmux-users
Are these all newer GCC -Wmaybe-uninitialized? I don't want to change
those because it might hide bugs and the compiler is clearly wrong and
will probably be fixed at some point.
> --
> You received this message because you are subscribed to the Google Groups "tmux-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to tmux-users+...@googlegroups.com.
> To view this discussion on the web, visit https://groups.google.com/d/msgid/tmux-users/20200405225634.301799-1-thomas%40xteddy.org.
Reply all
Reply to author
Forward
0 new messages