Why ignore attributes for menu-selected-style?

[japin li]

Hi,

I'm having trouble changing the style for menu-selected-style and menu-style.

Since the attributes are being ignored for these options.

I believe that being able to modify the menu-selected-style would be useful,

for example, I'd like to make the selected item in the menu bold.

Is there a specific reason why these attributes are being rejected?

[Nicholas Marriott]

I don't remember why this is, you can try this:

--- a/menu.c
+++ b/menu.c
@@ -453,7 +453,6 @@ menu_set_style(struct client *c, struct grid_cell *gc, const char *style,
                        gc->bg = sytmp.gc.bg;
                }
        }
-       gc->attr = 0;
 }

 struct menu_data *

--
You received this message because you are subscribed to the Google Groups "tmux-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tmux-users+...@googlegroups.com.
To view this discussion on the web, visit https://groups.google.com/d/msgid/tmux-users/191b5760-c799-4786-8309-91131c1ee41bn%40googlegroups.com.

[japin li]

On Monday, October 14, 2024 at 11:24:53 PM UTC+8 Nicholas Marriott wrote:

I don't remember why this is, you can try this:

--- a/menu.c
+++ b/menu.c
@@ -453,7 +453,6 @@ menu_set_style(struct client *c, struct grid_cell *gc, const char *style,
                        gc->bg = sytmp.gc.bg;
                }
        }
-       gc->attr = 0;
 }

 struct menu_data *

Yeah, I tried this, and it respects the attributes.  Do you have a plan to make it to the master branch?