notifiyTransaction should tell if no transaction is present

0 views
Skip to first unread message

Kjell Bublitz (@m3nt0r)

unread,
Jun 11, 2009, 5:16:54 PM6/11/09
to Tipjoy Developers, m3nt...@gmail.com
I am working on some fallbacks for my app and found out that
"notifyTransaction" does not check if the tweet is an transaction if
the twitterer is not a tipjoy user.

Example:
A) '@bob today is a rainy day' <-- "not a transaction"
B) 'give @bob $1 for a coat and a hat' <-- transaction"

Both examples fail and give as reason that @bob is not a tipjoy user.
So there is no way of telling which of these scenarios lead to the
failure.

Solution:
The "is-tipjoy-user-check" should come after "is-transaction-check".

Why?
If the tweet is not an transaction it is less important to me if, or
if not, the twitterer is a tipjoy user. I would just drop the tweet
and move on.

What do you think?
Reply all
Reply to author
Forward
0 new messages