Comment on revision r4470 in tinymux

[tin...@googlecode.com]

brazilofmux commented on revision r4470 in project tinymux.
Details are at http://code.google.com/p/tinymux/source/detail?r=4470

Score: Positive

General Comment:
Obviously, I'm generally positive about the change, but the changes should
not be promoted to dev branch until the code review items are fixed.

Line-by-line comments:

File: /branches/dev_brazil/mux/src/funmath.cpp (r4470)
===============================================================================

Line 2709: void sha1_helper(int nfargs, __in UTF8 *fargs[], __in UTF8
*buff, __deref_inout UTF8 **bufc)
-------------------------------------------------------------------------------
This function is dead code if SSL_ENABLED, and it should be excluded if
SSL_ENABLED is not #defined.

Respond to these comments at
http://code.google.com/p/tinymux/source/detail?r=4470
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings

[tin...@googlecode.com]

brazilofmux commented on revision r4470 in project tinymux.
Details are at http://code.google.com/p/tinymux/source/detail?r=4470

Score: Neutral

General Comment:
This feature also needs testcases for both digest() and sha1().