Groups keyboard shortcuts have been updated
Dismiss
See shortcuts

Go implementation of tn-cli

18 views
Skip to first unread message

Yinebeb Tariku

unread,
Feb 7, 2025, 12:25:10 PMFeb 7
to Tinode General

Hello Gene,

I am working on implementing tn-cli in Go, and I would be happy if you could follow my progress and review the code as I go. Here is a link to the draft PR:
https://github.com/tinode/chat/pull/935

Thanks!

Gene

unread,
Feb 7, 2025, 12:53:49 PMFeb 7
to Tinode General
Hi Yinebeb,

I'm sorry, but I don't see a lot of value in tn-cli if it's the same thing just written in another language. If you want I can link to your project from the main README, but I don't want to incorporate it into the main tree. If it's in the main tree then we would have to make sure it's always up to date and maintained. And would have to explain users which version they need - the python one or the go. Two version of the same thing are confusing.

As for reviewing your code, you don't have a single comment in your code. That's not a good practice.

Yinebeb Tariku

unread,
Feb 7, 2025, 1:02:50 PMFeb 7
to tin...@googlegroups.com

Ok, so we can close the PR  and I will do it in mine fork.

Thanks.


--
You received this message because you are subscribed to a topic in the Google Groups "Tinode General" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/tinode/0dd9BetA_BM/unsubscribe.
To unsubscribe from this group and all its topics, send an email to tinode+un...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/tinode/446cd0f0-6409-4969-aab8-a04e53c0cb81n%40googlegroups.com.
Reply all
Reply to author
Forward
0 new messages