What's needed to re-land RSS for categories?

[Hal Wine]

I'm new to Tinkerer, but a big Sphinx fan.

The one feature I need is per-category RSS feeds. It looks like this almost made in into Tinker with pull request #16. That needed to be backed out due to broken unit tests. (The main "all" feed moves from 'rss.html' to 'rss/all.html'.)

My question is, what's needed to get this to stick? I'd be willing to patch the patch to get it into the main line.

I assume just tweaking the tests to reflect the new position of the main feed isn't acceptable, as that would create a backward compatibility issue. What would an acceptable solution?

Thanks for everyone's work on Tinkerer!
--Hal

[Vlad Riscutia]

I think Robert had a similar pull request recently (https://bitbucket.org/vladris/tinkerer/pull-request/41/multi-rss-feed-support/diff), though with the new plug-in model, I believe this particular feature can go into tinkerer-contrib instead as it is not necessarily a core piece of Tinkerer. Not sure if Robert plans to refactor it into a plugin, otherwise you can take a look at the code and do it yourself. With the new design, I don't want to pull this into tinkerer but would gladly pull it to contrib.

Thank you,

Vlad

--Hal

--
You received this message because you are subscribed to the Google Groups "tinkerer-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tinkerer-dev...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

[Hal Wine]

On Sunday, February 24, 2013 12:43:43 PM UTC-8, vladris wrote:

I think Robert had a similar pull request recently (https://bitbucket.org/vladris/tinkerer/pull-request/41/multi-rss-feed-support/diff), though with the new plug-in model, I believe this particular feature can go into tinkerer-contrib instead as it is not necessarily a core piece of Tinkerer. Not sure if Robert plans to refactor it into a plugin, otherwise you can take a look at the code and do it yourself. With the new design, I don't want to pull this into tinkerer but would gladly pull it to contrib.

Vlad,

Thanks - I'll see if I can help Robert.

Can you point me to any docs on how the tinkerer-contib model is intended to work? I'm not finding a post about it, and it appears some features (e.g authorurl) are currently implemented in both places, leaving me confused on what goes where :)

--Hal

[Vlad Riscutia]

In short. tinkerer-contrib should consist of Sphinx extensions that apply to Tinkerer. Tinkerer passes around all its metadata via the context so extensions can leverage that. Authorurl is only in tinkerer-contrib and what it does is it hyperlink author name. Author extension in tinkerer provides the .. author: directive.

I have some details but didn't publish them online yet, will do soon:

https://bitbucket.org/vladris/tinkerer/src/tip/blog/pages/extensions.rst

https://bitbucket.org/vladris/tinkerer/src/tip/blog/doc/extensions.rst

Thank you,

Vlad

--