[HASM]

Fcc: +inbox
Subject: Re: [tigervnc-devel] Bug #1604 zaphod heads/full-screen problem
In-reply-to: <1f0e7150-3550-4fed...@cendio.se>
References: <1f0e7150-3550-4fed...@cendio.se>
Comments: In-reply-to Pierre Ossman <oss...@cendio.se>
message dated "Wed, 08 Mar 2023 07:41:52 +0100."
X-Mailer: MH-E 8.6+git; nmh 1.8; GNU Emacs 28.2
--------

>> A "simple" solution that works, IF AND ONLY IF,

> That's a massive if,

I know, that's why it was ALL IN CAPS :-)

> How about something like this:

Thanks.

I did say "someone on this mailing list could come up with
... much faster", where "someone" really meant you. I
wasn't really sure what was the "fltk" or "tigervnc"
preferred coding way of looking at the root window.

I'll try your solution soon/later today. As you said, more
or different events may need to looked at instead of
MotionNofity. I have a key combo that lets me jump between
screens, using xdotool, and have no idea which event that is
going to trigger.

-- Henrique

[HASM]

> I'll try your solution soon/later today.

Seems to work fine. Thanks!

My jump to another screen key combo doesn't real work unless
I disable the "pass special keys ..." option, and even in
that case it seems to work too. (And I never unchecked that
anyway.)

I'll use my locally built vncviewer until this makes it to
official Fedora rpm, no hurry on that.

-- Henrique

-----------------------------------------------------------------

Couple of (not so important) side notes.

I'm on Fedora 37.

I've been building fltk 1.3 and 1.4 from git, builds fine.
Didn't apply any Fedora src rpm patches for this, which may
or not explain some of the minor problems below.

Building vncviewer from git, with or without applying its
Fedora src rpm patches, results in a vncviewer that exits
almost immediately with ZRLE problems, either with an error
or core dump. This is probably my doing and wouldn't worry
too much about it.

Compiling from the src rpm succeeds in building vncviewer,
against either fltk 1.3 and 1.4, though against 1.4 it fails
sometime after that, I think building x0vncserver.

Also against 1.4 it initially errors out compiling
Viewport.cxx with an undefined LC_MESSAGES. I worked around
this by adding in gettext.h an include for locale.h, if
LC_MESSAGES is not defined, a little bit above the place
where it is first used in there.

Both the 1.3 and 1.4 based vncviewers work.

-----------------------------------------------------------------

[Pierre Ossman]

On 08/03/2023 16:53, HASM wrote:
>> I'll try your solution soon/later today.
>
> Seems to work fine. Thanks!
>
> My jump to another screen key combo doesn't real work unless
> I disable the "pass special keys ..." option, and even in
> that case it seems to work too. (And I never unchecked that
> anyway.)
>
> I'll use my locally built vncviewer until this makes it to
> official Fedora rpm, no hurry on that.
>

Thanks for testing. I've pushed the fix to master now.

>
> Compiling from the src rpm succeeds in building vncviewer,
> against either fltk 1.3 and 1.4, though against 1.4 it fails
> sometime after that, I think building x0vncserver.
>
> Also against 1.4 it initially errors out compiling
> Viewport.cxx with an undefined LC_MESSAGES. I worked around
> this by adding in gettext.h an include for locale.h, if
> LC_MESSAGES is not defined, a little bit above the place
> where it is first used in there.
>
> Both the 1.3 and 1.4 based vncviewers work.
>

You may be the first that tries compiling against 1.4, so I'm not
surprised there are some issues. :)

Regards
--
Pierre Ossman Software Development
Cendio AB http://cendio.com
Teknikringen 8 http://twitter.com/ThinLinc
583 30 Linköping http://facebook.com/ThinLinc
Phone: +46-13-214600

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?