[commit #11369] added visual indication of read-only mode

[s...@tiddlywiki.org]

http://trac.tiddlywiki.org/changeset/11369

FND
2010-01-04 02:28:23 -0800 (Mon, 04 Jan 2010)
110
added visual indication of read-only mode

Input fields are now grayed out (using TertiaryPale).

ticket #1126

---------------

U Trunk/core/js/Macros.js
U Trunk/core/shadows/StyleSheetColors.tiddler

---------------

Modified: Trunk/core/js/Macros.js
===================================================================
--- Trunk/core/js/Macros.js 2010-01-04 10:05:28 UTC (rev 11368)
+++ Trunk/core/js/Macros.js 2010-01-04 10:28:23 UTC (rev 11369)
@@ -130,7 +130,7 @@
return;
stack.push(tiddlerName);
try {
- if(typeof args == "string")
+ if(typeof args == "string")
args = args.readBracketedList();
var n = args ? Math.min(args.length,9) : 0;
for(var i=0; i<n; i++) {
@@ -170,8 +170,8 @@
var prompt = tiddler.tags.length == 0 ? lingo.labelNoTags : lingo.labelTags;
createTiddlyElement(ul,"li",null,"listTitle",prompt.format([tiddler.title]));
for(var t=0; t<tiddler.tags.length; t++) {
- var tag = store.getTiddler(tiddler.tags[t]);
- if(!tag || !tag.tags.contains("excludeLists")) {
+ var tag = store.getTiddler(tiddler.tags[t]);
+ if(!tag || !tag.tags.contains("excludeLists")) {
createTagButton(createTiddlyElement(ul,"li"),tiddler.tags[t],tiddler.title);
if(t<tiddler.tags.length-1)
createTiddlyText(ul,sep);
@@ -361,8 +361,6 @@
var e,v;
if(field != "text" && !rows) {
e = createTiddlyElement(null,"input");
- if(tiddler.isReadOnly())
- e.setAttribute("readOnly","readOnly");
e.setAttribute("edit",field);
e.setAttribute("type","text");
e.value = store.getValue(tiddler,field) || defVal;
@@ -373,8 +371,6 @@
var wrapper1 = createTiddlyElement(null,"fieldset",null,"fieldsetFix");
var wrapper2 = createTiddlyElement(wrapper1,"div");
e = createTiddlyElement(wrapper2,"textarea");
- if(tiddler.isReadOnly())
- e.setAttribute("readOnly","readOnly");
e.value = v = store.getValue(tiddler,field) || defVal;
rows = rows || 10;
var lines = v.match(/\n/mg);
@@ -386,6 +382,10 @@
e.setAttribute("edit",field);
place.appendChild(wrapper1);
}
+ if(tiddler.isReadOnly()) {
+ e.setAttribute("readOnly","readOnly");
+ addClass(e,"readOnly");
+ }
return e;
}
};

Modified: Trunk/core/shadows/StyleSheetColors.tiddler
===================================================================
--- Trunk/core/shadows/StyleSheetColors.tiddler 2010-01-04 10:05:28 UTC (rev 11368)
+++ Trunk/core/shadows/StyleSheetColors.tiddler 2010-01-04 10:28:23 UTC (rev 11369)
@@ -123,6 +123,7 @@
.editor input {border:1px solid [[ColorPalette::PrimaryMid]];}
.editor textarea {border:1px solid [[ColorPalette::PrimaryMid]]; width:100%;}
.editorFooter {color:[[ColorPalette::TertiaryMid]];}
+.readOnly {background:[[ColorPalette::TertiaryPale]];}

#backstageArea {background:[[ColorPalette::Foreground]]; color:[[ColorPalette::TertiaryMid]];}
#backstageArea a {background:[[ColorPalette::Foreground]]; color:[[ColorPalette::Background]]; border:none;}