[TW5] Request for enhancement: Add "skype" protocol
100 views
Skip to first unread message
Stephan Hradek
Oct 17, 2013, 10:04:11 AM10/17/13
to tiddly...@googlegroups.com
I just added it myself to $:/core/modules/widgets/link.js and $:/core/modules/parsers/wikiparser/rules/extlink.js
I changed /(?:file|http|https|mailto|ftp|irc|news|data) to /(?:file|http|https|mailto|ftp|irc|news|data|skype)
I changed /(?:file|http|https|mailto|ftp|irc|news|data) to /(?:file|http|https|mailto|ftp|irc|news|data|skype)
Jeremy Ruston
Oct 20, 2013, 5:49:34 AM10/20/13
to TiddlyWikiDev
Hi Stephan
Sorry for the delayed response - I've just pushed a new release that adds the "skype" protocol,
Best wishes
Jeremy
On Thu, Oct 17, 2013 at 3:04 PM, Stephan Hradek <stephan...@gmail.com> wrote:
I just added it myself to $:/core/modules/widgets/link.js and $:/core/modules/parsers/wikiparser/rules/extlink.js
I changed /(?:file|http|https|mailto|ftp|irc|news|data) to /(?:file|http|https|mailto|ftp|irc|news|data|skype)
--
You received this message because you are subscribed to the Google Groups "TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywikide...@googlegroups.com.
To post to this group, send email to tiddly...@googlegroups.com.
Visit this group at http://groups.google.com/group/tiddlywikidev.
For more options, visit https://groups.google.com/groups/opt_out.
Jeremy Ruston
mailto:jeremy...@gmail.com
Stephan Hradek
Oct 20, 2013, 7:00:07 AM10/20/13
to tiddly...@googlegroups.com, jeremy...@gmail.com
Great! Thanks!
Maybe a more general approach would also be good? After all a protocol (or better scheme name) is nothing but an identifier, so it starts with a letter and is followed by y any combination of letters, digits, plus ("+"), period ("."), or hyphen ("-") […] followed by a colon (":"). http://en.wikipedia.org/wiki/URI_scheme
So this should fit: /[a-z][a-z0-9+.-]*:/
Maybe a more general approach would also be good? After all a protocol (or better scheme name) is nothing but an identifier, so it starts with a letter and is followed by y any combination of letters, digits, plus ("+"), period ("."), or hyphen ("-") […] followed by a colon (":"). http://en.wikipedia.org/wiki/URI_scheme
So this should fit: /[a-z][a-z0-9+.-]*:/
Jeremy Ruston
Oct 21, 2013, 10:51:48 AM10/21/13
to Stephan Hradek, TiddlyWikiDev
There's a bit of history here. We've found in the past that such a broad match gives too many false positives, but it may be worth revisiting the issue. I'll code for a broader match in the present refactoring and we'll see where that goes. Otherwise my thinking is to make the protocol list be configurable, as noted in the commit:
Best wishes
Jeremy.
Reply all
Reply to author
Forward
0 new messages