[TW5] Tag Icon Color Not Auto Adjusting

[Taylor Jensen]

Depending on the color of a tag the text will change to be white or black, depending on which one gives greater contrast. Is there a way to extend this functionality to the icon as well (right now it's always white, even when the text is black)? Because of the way colorless SVGs work it seems like it would already be built in, or at the very least very doable.

I found almost nothing in the docs about it, but someone with more knowledge might be able to point me in the right direction.

-TCJ

[Tobias Beer]

Hi Taylor,

I made a pull request before that included a fix for the issue, see variable <<svg-style>>

Unfortunately, it was not merged at the time:

https://github.com/Jermolene/TiddlyWiki5/pull/2119

Best wishes,

Tobias.

[Taylor Jensen]

Ah, that is indeed the problem solved.

Hopefully that code manages to work its way into the core sometime. For now I can manually upgrade the relevant tiddlers. Good work!

-TCJ

[Tobias Beer]

Hi TCJ,

For now I can manually upgrade the relevant tiddlers. Good work!

With the kind of core tiddlers involved I cannot recommend you do that.
If you really feel this is utterly important you'd have to walk your way through the diff:

https://github.com/Jermolene/TiddlyWiki5/pull/2119/files

I cannot say that I would think it a worthy risk for the benefit.

Best wishes,

Tobias. 

[Taylor Jensen]

I agree; I haven't mucked around with the core files for such a silly feature. It was more of a "I've seen it work, and I know I could make it work, so I'm content".

-TCJ

[Taylor Jensen]

Any chance of getting this code in a future update? We already have it, might as well use it.