[TW5] For those who wants double click to edit

[Danielo Rodríguez]

Hello

Since a lot of people wants this, and TW is built by the community for the community and it should provide what community wants, here is a small plugin that can calm down your hunger for this feature. 

www.danielorodriguez.com/TW5-2click2edit

It is a very simple plugin focused on adding one functionality. Once installed, you have to "refresh" your tw to make it take effect..

As plugin claims, it is just a workaround. After TW add this functionality in core, it will become useless.

Hope you enjoy it.

[Sylvain Naudin]

Hi,

Just installed, tested, and.. approved !!

Thanks for this feature :)

[Odder]

Great!!!

Thank you very much Danielo.

[Jeremy Ruston]

Bravo Daniel, great stuff,

Best wishes

Jeremy

On Wed, Sep 2, 2015 at 1:20 PM, Odder <barg...@gmail.com> wrote:

Great!!!

Thank you very much Danielo.

--
You received this message because you are subscribed to the Google Groups "TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywiki+...@googlegroups.com.
To post to this group, send email to tiddl...@googlegroups.com.
Visit this group at http://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/1ba2a08f-ac8c-40c0-98fe-5b6664a1466b%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

Jeremy Ruston
mailto:jeremy...@gmail.com

[Felix Küppers]

Muchas gracias Danielo! I'll definitely put this in all my wikis. Is there a ticket at the TW5 github?

--
You received this message because you are subscribed to the Google Groups "TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywiki+...@googlegroups.com.
To post to this group, send email to tiddl...@googlegroups.com.
Visit this group at http://groups.google.com/group/tiddlywiki.

To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/c70503b1-3a55-429e-9ce6-3afd27e8e581%40googlegroups.com.

[Birthe C]

Hi Danielo,

Thank you so much for this.


Birthe

[Danielo Rodríguez]

El miércoles, 2 de septiembre de 2015, 14:23:08 (UTC+2), Felix Küppers escribió:

Muchas gracias Danielo! I'll definitely put this in all my wikis. Is there a ticket at the TW5 github?

De nada hombre!

If with ticket you mean repo, yes, there is one. It is on the plugin's "metadata". Basically If you remove my personal domain from the URL and add github.com/danielo515/ you have it:

https://github.com/danielo515/TW5-2click2edit

Glad you liked it

[Danielo Rodríguez]

El miércoles, 2 de septiembre de 2015, 14:22:04 (UTC+2), Jeremy Ruston escribió:

Bravo Daniel, great stuff,

Best wishes

Jeremy

It was just two hours work, including Github's repo and publication, so nothing big :D

Next step is to provide a UI to deactivate the function. It should be as easy as a checkbox that removes the view template tag from the appropriate tiddler. 

[Danielo Rodríguez]

Very welcome! 

[Danielo Rodríguez]

El miércoles, 2 de septiembre de 2015, 14:20:25 (UTC+2), Odder escribió:

Great!!!

Thank you very much Danielo.

Enjoy it! 

[Danielo Rodríguez]

El miércoles, 2 de septiembre de 2015, 14:23:08 (UTC+2), Felix Küppers escribió:

Muchas gracias Danielo! 

By the way, I thought you were against this feature. Am I taking you as a different person? 

[Alex Hough]

Dear Danielo,

It's long overdue.... what can I say.... many thanks!

Alex

--

You received this message because you are subscribed to the Google Groups "TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywiki+...@googlegroups.com.
To post to this group, send email to tiddl...@googlegroups.com.
Visit this group at http://groups.google.com/group/tiddlywiki.

To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/08a3a874-c14b-47ac-b24b-7715ea8f630e%40googlegroups.com.

[Mat]

Well done Danielo - but I should also add that I think this feature should remain a plugin and not be core. The idea to double click on a document to have it change into edit mode is...very strange IMO. (I wish the Sticky titlebar feature would work tho so that the edit button is always immediately accessible.)

<:-)

[HansWobbe]

Danielo:

Thank you, indeed!

~~ Hans

[Sergio Rolim]

Very good!!!!

[Jon]

Many thanks Danielo - very useful indeed.

I also agree with Mat, that it would be better to keep this behaviour as an option rather than make it default so that people can choose what works best for them.

Jon

[Felix Küppers]

I hope I am not suffering schizophrenia but I am pretty sure that wasn't me :D

[PMario]

On Wednesday, September 2, 2015 at 7:11:53 PM UTC+2, Danielo Rodríguez wrote:

IMO as a plugin this function is great but by default it should be switched of.

--------------------

The reason, why the double click behaviour is not part of vanilla TW is, that it caused a lot of problems with "site visitors" / "content consumers" in TWc. It's convenient for content producers only.

eg:
If a consumer wants to "double click select" content to copy paste it, TWc opens the plain text, which is extremely confusing.

As a visitor I'm not interested in the innards of a page. I just want to interact with the UI, not the backend.

-m

[Danielo Rodríguez]

I'm glad that so many people is finding it useful.

What seems to be not clear is that I am totally against integrating this into the core. That's why I have created a plugin instead of a pull request. I know that I wrote that this will be only useful until it becomes officially supported by core, but I never wanted that to happen :D

And, at the end, even if I wanted it is not my decision, I'm just a plugin maker ;)

[PMario]

I think, that's the way new functionality should go, from now on. ... TW core itself imo is pretty stable. We have great "out of the box" possibilities. .. We will always need to improve the documentation :) But imo we should try to keep the core as small as possible.

So if new and "great" functionality comes up as plugins first, we (the community) can use and improve it. If the pros and cons are discussed and the plugin is battle tested, there is still the possibility to create a pull request for the core.

just my thoughts.

have fun!
mario

[Tobias Beer]

Hi Danielo,

I like this. :-)

One thing...

My browser seems to automagically correct it,

but isn't it a problem to just put an opening tag

in a ViewTemplate section and then never close it?

title: $:/plugins/danielo515/2click2edit/ui/ViewTemplate
tags: $:/tags/ViewTemplate

<$click>

Also, why doesn't this need any...

list-before:

...to make it the first viewtemplate-section being rendered?

When I click on the tagpill for $:/tags/ViewTemplate, it is listed last.

Or rather, how come it affects the entire ViewTemplate?

Best wishes,

— tb

[Danielo Rodríguez]

Hello Tobias,

The widget is not actually an Html element, so it does not behave like a regular element. It is wikitext, so it is actually parsed by tiddlywiky and inserted into the widget tree, that's why it is not an issue to not close it. I'm not sure about the specification and how widgets should be created, probably Jeremy can throw some light on this. There is no render before field because it does not matter where the plugin is as long as it is a direct child of the tiddler node. It just attach a listener to its parent, it does not do anything itself.

Regards

[Jeremy Ruston]

Hi Danielo

The widget is not actually an Html element, so it does not behave like a regular element. It is wikitext, so it is actually parsed by tiddlywiky and inserted into the widget tree, that's why it is not an issue to not close it. I'm not sure about the specification and how widgets should be created, probably Jeremy can throw some light on this. There is no render before field because it does not matter where the plugin is as long as it is a direct child of the tiddler node. It just attach a listener to its parent, it does not do anything itself.

Within wikitext, both HTML elements and widgets are parsed by the same parse rule:

https://github.com/Jermolene/TiddlyWiki5/blob/master/core/modules/parsers/wikiparser/rules/html.js

If the end tag is missing it defaults to the end of the tiddler or macro containing the starting tag.

Personally, it feels more correct to use <$click/>, and close the tag explicitly, to avoid readers thinking that the text has been truncated.

Best wishes

Jeremy.

 

Regards

--
You received this message because you are subscribed to the Google Groups "TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywiki+...@googlegroups.com.
To post to this group, send email to tiddl...@googlegroups.com.
Visit this group at http://groups.google.com/group/tiddlywiki.

To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/f419385f-03b4-4da0-bd21-ad4271aa4649%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

[Danielo Rodríguez]

Within wikitext, both HTML elements and widgets are parsed by the same parse rule:

https://github.com/Jermolene/TiddlyWiki5/blob/master/core/modules/parsers/wikiparser/rules/html.js

If the end tag is missing it defaults to the end of the tiddler or macro containing the starting tag.

Personally, it feels more correct to use <$click/>, and close the tag explicitly, to avoid readers thinking that the text has been truncated.

Hello Jeremy, thank you very much for the explanation! I'll fix it. 

[Tobias Beer]

Hi Danielo,

 

It just attach a listener to its parent, it does not do anything itself.

 

Argh, these moments when I'm not paying close attention.

Taking a second look, I can see how your widget

attaches an event listener to its parent, the tiddler.
A neat little trick, to work the DOM nonetheless. ^_^

Best wishes,

— tb

[Eli Du]

Thank you so much for this! Works great and adds a lot of usability to TW5!