Tinka and TW 5.1.19+ Issue

[Mohammad]

As Ton Gerner stated here

https://groups.google.com/d/msg/tiddlywikidev/W6epqYBZyRU/tXNv7UOGDgAJ

Tinka has stopped working as TW 5.1.19. My experiments shows it has problem also with 5.1.18 final release, but works in 5.1.18pre.

I re-post the issue here to see if the author Andreas Hahn is notified to have a look at the plugin.

I also kindly ask Simon to check and see if there is something changed from TW side.

Tinka is a very popular plugin and we hope keep it working with the new release of Tiddlywiki

Thank you 

Mohammad

[Joshua Fontany]

I may have a solution to this with my latest build of the JsonMangler plugin. I'm almost to the point where I can read/write to packed plugins using just the native tiddlywiki UI elements, actions, etc. Doing some final testing before I release it. I'm taking inspiration from Tinka and adding a ControlPanel element & recreating some of the Tinka ui style.

This was inspired by your request for more examples. Thanks Mohammad.

More soon. :)

Joshua Fontany

[Mohammad]

Many thanks Josuha,

Looking forward to see your solution.

Cheers

Mohammad

[David Nebauer]

Subsequent posts in the thread explain further that the plugin is built successfully despite the javascript error. The same has happened to me (TW5.1.19, Tinka 0.4.0) though the internal javascript error I get is "Uncaught TypeError: Cannot read property 'ownerDocument' of undefined". This has occurred every time I built a plugin using Tinka. (All three of them!)

David.  

[Andreas Hahn]

Hi,

thank you for posting this and looking into it, I'll have a look at it
soon and see if I can come up with a solution to get it working properly
and future-poof it for the 5.1.20 release.

/Andreas

[Andreas Hahn]

Dear Mohammad,

I'm currently debating whether or not its even worth fixing it, since
the whole issue seems to be caused by a bug in TW itself, which is
already fixed for the upcoming 5.1.20 (see [1]). So just waiting means
that things will repair themselves. There is a way to create a
workaround for older versions, but it would be unfortunate to have that
be in widespread use.

Did anyone run into any issues in the 5.1.20 prerelease?

/Andreas


[1]
https://github.com/Jermolene/TiddlyWiki5/commit/95dbdff08a788673f892ce23468c68fbb63a1cc3#diff-8cd38385e5ecdcb70371acfa849ab3e8

[Mohammad]

Hi Andreas,

 I will make some experiment with TW 5.1.20pre and will let you know the results.

Cheers

Mohammad

[@TiddlyTweeter]

Ciao Andreas

I don't think to give energy to a workaround when the .20 pre-release is there already that appears to solve the issue in .19 is worth the effort.

All that is needed, I think, is users know. So announcement about that might be worth it?

My two cents

Best wishes

Josiah 

[Mohammad]

Hi Andreas,

I tested the Tinka 0.4 with Tiddlywiki 5.1.21pre and it works like 

charm. Thank you Andreas.

--Mohammad 

On Sunday, February 17, 2019 at 1:48:32 PM UTC+3:30, Andreas Hahn wrote: