v5.1.10 : Checkbox to add contents below river not working

[Alex Hough]

Dear All,

Reporting this as a potential bug

I cut and pasted the following into a new tiddler on TiddlyWiki.com

<$checkbox tag="$:/tags/TopLeftBar">Top l eft</$checkbox>

<$checkbox tag="$:/tags/TopRightBar">Top right</$checkbox>

<$checkbox tag="$:/tags/AboveStory">above</$checkbox>

<$checkbox tag="$:/tags/BelowStory ">below</$checkbox>

The adding the tag "$:/tags/BelowStory" in this way doesn't result in the tiddler's content being displayed below the river.

If you 'new here' from $:/tags/BelowStory - contents are not added below

same with cloning a tiddler with this tag.

If you edit the clone, delete the tag then add it again, then the contents are added.

best wishes

Alex

[Tobias Beer]

Hi Alex,

If you want to use the checkbox-widget outside the story, you either need to:

1. set the tiddler attribute
2. wrap it all in a TiddlerWidget
3. use a widget to set the currentTiddler variable, e.g. the VarsWidget:

title: $:/config/position/foo

<$vars currentTiddler="$:/config/position/foo">

<$checkbox tag="$:/tags/TopLeftBar">Top l eft</$checkbox>

<$checkbox tag="$:/tags/TopRightBar">Top right</$checkbox>

<$checkbox tag="$:/tags/AboveStory">above</$checkbox>

<$checkbox tag="$:/tags/BelowStory">below</$checkbox>

</$vars>

Best wishes,

Tobias. 

[PMario]

Hi Alex,
It works, if you remove the trailing space.

<$checkbox tag="$:/tags/TopLeftBar">Top l eft</$checkbox>

<$checkbox tag="$:/tags/TopRightBar">Top right</$checkbox>

<$checkbox tag="$:/tags/AboveStory">above</$checkbox>

<$checkbox tag="$:/tags/BelowStory ">below</$checkbox>        

                                  ^
                                  |--- see the trailing space here

This is a known behaviour, with a won't fix tag.

-mario

[Tobias Beer]

 Hi Mario,

 

It works, if you remove the trailing space.

Did you actually try clicking the checkboxes in the topleftbar or toprightbar?

 

<$checkbox tag="$:/tags/BelowStory ">below</$checkbox>        
                                  ^
                                  |--- see the trailing space here

This is a known behaviour, with a won't fix tag.

Can you point to an issue that says so?

To me, leading or trailing spaces are or should

not be allowed for titles... including tags.

Best wishes,

Tobias. 

[PMario]

On Sunday, January 10, 2016 at 6:59:21 PM UTC+1, Tobias Beer wrote:

This is a known behaviour, with a won't fix tag.

Can you point to an issue that sais so?

To me, leading or trailing spaces are or should

not be allowed for titles... including tags.

see: Tiddler title handling should trim whitespace -- https://github.com/Jermolene/TiddlyWiki5/issues/751

There may be others too, but I can't find them.

-m

[Alex Hough]

@mario!

i'd have never spotted it

best wishes

Alex

On 10 January 2016 at 17:59, Tobias Beer <beert...@gmail.com> wrote:

 Hi Mario,

 

It works, if you remove the trailing space.

Did you actually try clicking the checkboxes in the topleftbar or toprightbar?

 

<$checkbox tag="$:/tags/BelowStory ">below</$checkbox>        
                                  ^
                                  |--- see the trailing space here

This is a known behaviour, with a won't fix tag.

Can you point to an issue that sais so?

To me, leading or trailing spaces are or should

not be allowed for titles... including tags.

Best wishes,

Tobias. 

--
You received this message because you are subscribed to the Google Groups "TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywiki+...@googlegroups.com.
To post to this group, send email to tiddl...@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/5b15b266-2140-4dcf-83e7-77501dae24ff%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

[Tobias Beer]

Hi Mario, 

 

see: Tiddler title handling should trim whitespace -- https://github.com/Jermolene/TiddlyWiki5/issues/751

There may be others too, but I can't find them.

I've read issue 751 before and couldn't help but spot Jeremy's comment (next to a reminder about backwards-"compatibility"):

As I say, the debate is probably academic because the semantics of the store are already established.

I couldn't resist but leave another comment to an issue that shouldn't be closed:

I don't really think there's anything academic to this:

1. Leading or trailing white-space in titles as well as field-names must not be supported.
2. If any layer allows it, it is to be considered a bug that needs fixing.

Best wishes,

Tobias.

[Alex Hough]

Hi Mario, Tobias,

Jermery: "If we trim spaces from the start and end of strings then we're teaching users that spaces don't matter. But in fact there are intentionally many places where spaces do matter [1]"

For me, while infuriating, I will probably keep a more keen eye out for these type of errors. 

Alex

[1] https://github.com/Jermolene/TiddlyWiki5/issues/751#issuecomment-55717364

--

You received this message because you are subscribed to the Google Groups "TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywiki+...@googlegroups.com.
To post to this group, send email to tiddl...@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywiki.

To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/ba388c37-59de-4206-8fea-e01d0767cca3%40googlegroups.com.