TW 5.1.22prerelease: the tabs macro with tc-vertical class: Is this an issue?

110 views
Skip to first unread message

Mohammad

unread,
Oct 19, 2019, 11:38:30 AM10/19/19
to TiddlyWiki
The attached tiddlers reproduce an issue of overflow in TW 5.1.22

It seem the text in vertical tab overflows when a column layout is used.

Download the attached .json and import into



and




and then look at the

Vertical tabs/multicols Tiddler.

5.1.21 works fine but in 5.1.22p the tabs cannot display text correctly and it overflows.


--Mohammad
verticalTab-issue-5.1.22.json

Mohammad

unread,
Oct 19, 2019, 11:53:01 PM10/19/19
to TiddlyWiki
For a temporary solution, I just import the $:/themes/tiddlywiki/vanilla/base
from 5.1.21 into 5.1.22 and it works fine for now!

Seems issue is related to recent update of Normalize.css from 3.0 to 8.0

--Mohammad

Mohammad

unread,
Oct 20, 2019, 1:13:04 AM10/20/19
to TiddlyWiki
Further input:

I realized if I change the below css

Edit the $:/themes/tiddlywiki/vanilla/base as below
  • find the below part (1)

    .tc-tab-content.tc-vertical  {
        word-break: break-word;
  • change it as below (2)

    .tc-tab-content.tc-vertical  {
     /*   word-break: break-word;*/

With 1, I have annoying word break in tables inside vertical tab
With 2, I have the text overflow in vertical tab when I use multi column layout as explained in the first post of this thread!

--Mohammad



On Saturday, October 19, 2019 at 7:08:30 PM UTC+3:30, Mohammad wrote:

Jeremy Ruston

unread,
Oct 20, 2019, 5:48:26 AM10/20/19
to tiddl...@googlegroups.com
Hi Mohammad

I’ve just commited a different fix, setting overflow: auto on the container:


Let me know how it works for you. (The prerelease build will be done in about 8 minutes),

Best wishes

Jeremy

-- 
You received this message because you are subscribed to the Google Groups "TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywiki+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/1be47d72-361d-4aec-8ef2-1ff0f69c3927%40googlegroups.com.

Mohammad

unread,
Oct 20, 2019, 9:39:50 AM10/20/19
to TiddlyWiki
Hi Jeremy
Thank you! I am testing the new css settings and I will return with results.

Best
Mohammad


On Sunday, October 20, 2019 at 1:18:26 PM UTC+3:30, Jeremy Ruston wrote:
Hi Mohammad

I’ve just commited a different fix, setting overflow: auto on the container:


Let me know how it works for you. (The prerelease build will be done in about 8 minutes),

Best wishes

Jeremy

To unsubscribe from this group and stop receiving emails from it, send an email to tiddl...@googlegroups.com.

Mohammad

unread,
Oct 20, 2019, 3:13:38 PM10/20/19
to TiddlyWiki
Hi Jeremy!

It seems it works for me. I have tested it with Shiraz!

Now both table and multi column layout does not overflow.

I will report if I found any issue.

--Mohammad 


On Sunday, October 20, 2019 at 1:18:26 PM UTC+3:30, Jeremy Ruston wrote:
Hi Mohammad

I’ve just commited a different fix, setting overflow: auto on the container:


Let me know how it works for you. (The prerelease build will be done in about 8 minutes),

Best wishes

Jeremy

To unsubscribe from this group and stop receiving emails from it, send an email to tiddl...@googlegroups.com.
Reply all
Reply to author
Forward
0 new messages