Bug report: Creating New Journal Tiddler deletes existing Journal Tiddler

[Michael Wiktowy]

Greetings all,

Description:

There is an issue using the "Create a new journal tiddler" button when there is an existing one of the same name. Rather then use one of the existing name collision mechanisms (opening existing tiddler for editing, appending an incremental index on to the tiddler name or putting a warning banner that an existing tiddler exists with the same name), a new empty tiddler is opened with the same name and if it is saved instead of cancelled, the old existing journal is overwritten without warning.

Method to reproduce:

1) Create a journal entry.

2) Within the same time increment that would create another journal entry of the same name (different depending on the "Title of new journal tiddlers" format in settings), create a new one using the "Create a new Journal Tiddler" button.

3) Save newly created tiddler.

4) Previous journal tiddler gets deleted without warning

Expected Results:

Step 2) should load the existing tiddler to edit , or

Step 3) should give a warning that an existing tiddler of the same name exists either in the editing toolbar or an "Are you sure?"-type popup on saving.

Thanks,

/Mike

[Mat]

Confirmed!

Definitely a bug.
Could you post this on github?

<:-)

[Rob Hoelz]

It's already reported: https://github.com/Jermolene/TiddlyWiki5/issues/2845

Until a fix is released, you could just fix your $:/core/ui/PageControls/new-journal.tid

-Rob

[Michael Wiktowy]

Thanks. That matches my problem and, while a related problem from 2009 turned up in a google search, this didn't.

I didn't see the details of a new-journal.tid workaround in that thread and am hesitant to start poking around in the system tiddlers. Knowing about the problem makes it easy to work around. I just didn't want it catching new users with data loss.

/Mike

[Diego Mesa]

Rob,

Could you suggest a fix?

[Alexander Smit]

I'm not on Github.. I just figured the "New journal here"-button actually does opens a journal tiddler allready created with a same date. However, in that case it doesn't add the label of the 2nd tiddles it is opened from. neither it autosaves on confirming.

[Jeremy Ruston]

I think the problem in the original post is fixed in 5.1.15.

Best wishes

Jeremy

--

Jeremy Ruston

jer...@jermolene.com

https://jermolene.com

--
You received this message because you are subscribed to the Google Groups "TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywiki+...@googlegroups.com.
To post to this group, send email to tiddl...@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/6f85dec2-3cea-42f3-970a-c10c27a1453d%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Diego Mesa]

Hm I might be missing something silly, but I'm on 5.1.15 but I still see this behavior. 

[TonyM]

Try a fresh Wiki perhaps,

I am not getting this behaviour on new Jounal, New Journal here or via the below macro.

Subsequent clicks open an existing tiddler for edit and retaining the orginal content

\define todayentry()

<$button tooltip="Create or Open Today entry">

{{$:/core/images/new-journal-button}}

<$action-sendmessage $message="tm-new-tiddler" title=<<now YYYY-0MM-0DD>> tags="Journal">>" />

\end

Regards

Tony

[Diego Mesa]

Hey Tony,

You're right - the problem is my Custom New Research Journal Button. I cant track down whats wrong with it though attached are the two files I've modified, based on tobias' tutorial.

Any help with this would be greatly appreciated! 

[Michael Wiktowy]

Yes, it was fixed. Just tested it with the standard 5.1.15 tiddlywiki. Thank you.

/Mike

To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywiki+unsubscribe@googlegroups.com.

To post to this group, send email to tiddl...@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/6f85dec2-3cea-42f3-970a-c10c27a1453d%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to a topic in the Google Groups "TiddlyWiki" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/tiddlywiki/3zBqF4MA9WU/unsubscribe.
To unsubscribe from this group and all its topics, send an email to tiddlywiki+unsubscribe@googlegroups.com.

To post to this group, send email to tiddl...@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywiki.

To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/15115D36-27FD-49BB-9E22-7B84249B6D2D%40gmail.com.

For more options, visit https://groups.google.com/d/optout.

--

Michael Wiktowy mwik...@gmail.com

[Diego Mesa]

Hey all,

I figured out what my issue has been all along. This issue can be seen with the default new journal button on tiddlywiki.com:

Steps to reproduce:

1. Go to tiddlywiki.com, and create a new journal entry (using the button, or manually) and type in "Test journal entry text" and save.

2. Open the shadow tiddler: $:/config/NewJournal/Text and type: "overwrite text" and save.

3. Press the new journal button again

Desired Result:

Pressing this button should open the already existing journal entry, OR create a new one with a (1) after the name with "overwrite tex"

Actual Result:

A tiddler with the same title as today's journal is opened whose content is "overwrite text". If this is saved, it will overwrite your journal entry! If this is instead discarded, you get back your original journal entry.

I believe this is a bug?

Diego

To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywiki+...@googlegroups.com.

To post to this group, send email to tiddl...@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/6f85dec2-3cea-42f3-970a-c10c27a1453d%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to a topic in the Google Groups "TiddlyWiki" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/tiddlywiki/3zBqF4MA9WU/unsubscribe.

To unsubscribe from this group and all its topics, send an email to tiddlywiki+...@googlegroups.com.

To post to this group, send email to tiddl...@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywiki.

To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/15115D36-27FD-49BB-9E22-7B84249B6D2D%40gmail.com.

For more options, visit https://groups.google.com/d/optout.

--

Michael Wiktowy mwik...@gmail.com

[TonyM]

Diego,

In my test Wiki the default new journal twice opens the existing one and retains the content. 

I have followed the create new Journal button instructions before and found it cumbersome.

Now I use my own macro; eg

\define todayentry()

<$button tooltip="Create or Open Today entry">

{{$:/core/images/new-journal-button}}

<$action-sendmessage $message="tm-new-tiddler" title=<<now YYYY-0MM-0DD>> tags="Journal">>" />

\end

You can make this as sophisticated as you want.

Regards

Tony

<<todayentry>> 

[Diego Mesa]

Hey Tony,

Sorry I'm not sure what you mean about retaining the text? I agree that hitting that button will just open the existing tiddler in edit mode. The crucial step in my "bug report" above is step 2 where you add text to $:/config/NewJournal/Text 

[TonyM]

I understand,

Whilst it is a bug, it is also doing as asked, by having no text it was "open[ing] the existing tiddler in edit mode" for me an no problems as a result.

My point is I have abandoned the New Journal button and created my own for total control. Not only is it a work around but possibly a better solution all together.

If this is out of topic, sorry, just trying to add to the conversation. Should it help.

It is not always possible to keep track of the expertise level of every contributor.

Regards

Tony

[Diego Mesa]

Thanks for clarifying Tony! I just wanst sure if you were able to replicate my steps I've had some trouble on here in the past with that. 

I too am frustrated by it, and very much appreciate your suggestion of bypassing it all together!