TTTableSubtextItem text overflow when using UITableViewStyleGrouped

[Nic Hubbard]

I am using a TTTableSubtextItem and I am constantly getting text
overflowing out of my table cell. This only happens when I am using
UITableViewStyleGrouped (which I do want to use), but not when I use
UITableViewStylePlain.

Is there some bug in the rowHeightForObject method that does not
account for using a Grouped TableView?

See: http://www.puc.edu/__data/assets/image/0011/78806/Screen-shot-2011-02-01-at-11.33.00-AM.png

[Mike Morearty]

You're right, looks like they calculated the cell height wrong.  I've submitted a patch.

[Nic Hubbard]

Thank you!

On Feb 2, 7:21 pm, Mike Morearty <m...@morearty.com> wrote:
> You're right, looks like they calculated the cell height wrong.  I've

> submitted a patch <https://github.com/facebook/three20/pull/381>.

[Philip Walton]

The patch that Mike submitted is not quite correct. It ignores the fact
that a TTTableSubtextItem can have a URL property, thus an
accessoryView, which will take away 20 more pixels from the width.

This is what I've done to deal with that.

CGFloat accessoryViewWidth = item.URL ? 20.0 : 0.0;
CGFloat width = tableView.width - [tableView tableCellMargin]*2 -
kTableCellHPadding*2 - accessoryViewWidth;

Mike, unless I'm missing something, you might want to add this to your
patch.

[Mike Morearty]

Very good point, Philip -- but the same appears to be true of almost all of the item types that can have a URL (which is to say, almost all the subclasses of TTTableLinkedItem).  TTStyledTextTableItemCell seems to be the only cell type that tries to adjust for this.

So rather than fix just the one case of TTTableSubtextItem by modifying this patch, I've logged a separate bug for the URL issue.  https://github.com/facebook/three20/issues/429

[Philip Walton]

Thanks Mike, I suspected that was probably the case.

> --
> You received this message because you are subscribed to the Google
> Groups "Three20" group.
> To post to this group, send email to thr...@googlegroups.com
> To unsubscribe from this group, send email to
> three20+u...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/three20?hl=en
>
> To learn more about Three20, check out
> http://Three20.info/