[thg-dev] [PATCH 0 of 1 ] Goto revision v2

[Sune Foldager]

I changed the hotkey to CTRL+R which isn't used or reserved (and stands for Revision), and fixed my user name. Are there any big problems with expanding this to a QCompleter solution later on? I can work on that as well, but I still think it's better than nothing like this.

We might pop up a message box for unknown revisions, that's another small improvement.

------------------------------------------------------------------------------
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
_______________________________________________
Tortoisehg-develop mailing list
Tortoiseh...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tortoisehg-develop

[Sune Foldager]

# HG changeset patch
# User Sune Foldager <cr...@cyanite.org>
# Date 1321364343 -3600
# Node ID 3167586c9b264c22c2fcf655f5b83ed112fb43db
# Parent 7c77449be71d072e2ab468abf92c28a5b2695836
workbench: add "Goto revision" command

diff -r 7c77449be71d -r 3167586c9b26 tortoisehg/hgqt/workbench.py
--- a/tortoisehg/hgqt/workbench.py Wed Nov 09 22:26:06 2011 -0600
+++ b/tortoisehg/hgqt/workbench.py Tue Nov 15 14:39:03 2011 +0100
@@ -300,6 +300,9 @@
newaction(_("Load all revisions"), self.loadall,
enabled='repoopen', menu='view', shortcut='Shift+Ctrl+A',
tooltip=_('Load all revisions into graph'))
+ newaction(_("&Goto revision"), self.gotorev,
+ enabled='repoopen', menu='view', shortcut='Ctrl+R',
+ tooltip=_('Go to a specific revision'))

newaction(_("Web Server..."), self.serve, enabled='repoopen',
menu='repository')
@@ -724,6 +727,13 @@
if w:
w.repoview.model().loadall()

+ def gotorev(self):
+ rev, ok = QInputDialog.getText(self, "Goto revision",
+ "Enter revision identifier")
+ w = self.repoTabsWidget.currentWidget()
+ if ok and w:
+ w.repoview.goto(rev)
+
def newRepository(self):
""" Run init dialog """
from tortoisehg.hgqt.hginit import InitDialog

[Steve Borho]

On Tue, Nov 15, 2011 at 7:43 AM, Sune Foldager <cya...@me.com> wrote:
> I changed the hotkey to CTRL+R which isn't used or reserved (and stands for Revision), and fixed my user name. Are there any big problems with expanding this to a QCompleter solution later on? I can work on that as well, but I still think it's better than nothing like this.

http://doc.qt.nokia.com/stable/qkeysequence.html

CTRL+R is "refresh" on Linux. I recommend CTRL+SHIFT+G, FWIW

Adding the QCompleter as a second patch would be fine.

> We might pop up a message box for unknown revisions, that's another small improvement.

Would be nice.

--
Steve Borho

[Marcel]

Why not having different shortcuts on different systems?

I, as Windows user, like CTRL+G.

On 15.11.2011 21:13, Steve Borho wrote:
> On Tue, Nov 15, 2011 at 7:43 AM, Sune Foldager<cya...@me.com> wrote:
>> I changed the hotkey to CTRL+R which isn't used or reserved (and stands for Revision), and fixed my user name. Are there any big problems with expanding this to a QCompleter solution later on? I can work on that as well, but I still think it's better than nothing like this.
>
> http://doc.qt.nokia.com/stable/qkeysequence.html
>
> CTRL+R is "refresh" on Linux. I recommend CTRL+SHIFT+G, FWIW
>
> Adding the QCompleter as a second patch would be fine.
>
>> We might pop up a message box for unknown revisions, that's another small improvement.
>
> Would be nice.
>

------------------------------------------------------------------------------

[Sune Foldager]

On 15-11-2011 21:20, Marcel wrote:
> Why not having different shortcuts on different systems?
>
> I, as Windows user, like CTRL+G.

Me too, but it does seem to be used for find next in the thg workbench
after using CTRL+F to search in the patch text. Of course F3 works there
as well...

> On 15.11.2011 21:13, Steve Borho wrote:
>> On Tue, Nov 15, 2011 at 7:43 AM, Sune Foldager<cya...@me.com> wrote:
>>> I changed the hotkey to CTRL+R which isn't used or reserved (and stands for Revision), and fixed my user name. Are there any big problems with expanding this to a QCompleter solution later on? I can work on that as well, but I still think it's better than nothing like this.
>>
>> http://doc.qt.nokia.com/stable/qkeysequence.html
>>
>> CTRL+R is "refresh" on Linux. I recommend CTRL+SHIFT+G, FWIW

Right, I agree with that, I think. Also somewhat more intuitive than
CTRL+R even though it's an extra key.

>> Adding the QCompleter as a second patch would be fine.

Yeah, it's been like a million years since I did QT coding, so I'll have
to ease into it ;)

>>> We might pop up a message box for unknown revisions, that's another small improvement.
>>
>> Would be nice.

I'll try to put that in and resubmit.

/Sune

------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d