[PATCH 1 of 2] makefile: apply consistently the checks on HGPATH to the "app" target, too

1 view
Skip to first unread message

Antonio Muci

unread,
Mar 24, 2025, 8:52:40 AMMar 24
to thg...@googlegroups.com, a....@inwind.it
# HG changeset patch
# User Antonio Muci <a....@inwind.it>
# Date 1742820348 -3600
# Mon Mar 24 13:45:48 2025 +0100
# Branch stable
# Node ID 22f03f8eddce89c39a6277dd41144d47b5b8e571
# Parent 337ca247ceedf07f5260ab92816adb03b9a854d3
makefile: apply consistently the checks on HGPATH to the "app" target, too

This was an oversight in the previous two commits: it should have been part of
those.

diff --git a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -56,8 +56,9 @@ app: DISTDIR = dist/app
app: SETUPCFG = contrib/setup-py2app.cfg
app: export MACOSX_DEPLOYMENT_TARGET=10.7
app:
- @[ -n "$(HGPATH)" ] || { echo "HGPATH not specified"; false; }
- @[ -d "$(HGPATH)" ] || { echo "HGPATH not found: $(HGPATH)"; false; }
+ @[ -n "$(HGPATH)" ] || { echo "HGPATH not specified. Please run again with 'make $@ HGPATH=/path/to/hg'. For example, you could point to a checkout of the mercurial source code"; false; }
+ @[ -e "$(HGPATH)" ] || { echo "HGPATH not found: $(HGPATH)"; false; }
+ @[ -d "$(HGPATH)" ] || { echo "HGPATH must be a directory: $(HGPATH)"; false; }
[ -z "$(SETUPCFG)" ] || cp "$(SETUPCFG)" setup.cfg
$(MAKE) -C "$(HGPATH)" local
FORCE_SETUPTOOLS= $(PYTHON) setup.py py2app -d "$(DISTDIR)"

Yuya Nishihara

unread,
Mar 24, 2025, 11:47:37 AMMar 24
to 'Antonio Muci' via TortoiseHg Developers, a....@inwind.it
On Mon, 24 Mar 2025 13:52:36 +0100, 'Antonio Muci' via TortoiseHg
Developers wrote:
> # HG changeset patch
> # User Antonio Muci <a....@inwind.it>
> # Date 1742820348 -3600
> # Mon Mar 24 13:45:48 2025 +0100
> # Branch stable
> # Node ID 22f03f8eddce89c39a6277dd41144d47b5b8e571
> # Parent 337ca247ceedf07f5260ab92816adb03b9a854d3
> makefile: apply consistently the checks on HGPATH to the "app"
> target, too

Queued, thanks.
Reply all
Reply to author
Forward
0 new messages