[PATCH 1 of 8 DarkThemeSeries 2] docklog: fix QProcess.start() call for PyQt6 compatibility

6 views
Skip to first unread message

Peter Demcak

unread,
Mar 6, 2026, 2:42:57 PM (4 days ago) Mar 6
to thg...@googlegroups.com
# HG changeset patch
# User Peter Demcak <majs...@gmail.com>
# Date 1772737121 -3600
# Thu Mar 05 19:58:41 2026 +0100
# Node ID 4ff067cd6020d6635b8237f57912512d9feb0482
# Parent d4ed04c8da7120737437170dea6c3aed83978ae8
docklog: fix QProcess.start() call for PyQt6 compatibility

In PyQt6, passing the open mode as a positional argument to
QProcess.start(program, mode) is ambiguous with the overloaded
start(program, arguments, mode) signature, causing a TypeError.
Pass mode as a keyword argument instead.

diff -r d4ed04c8da71 -r 4ff067cd6020 tortoisehg/hgqt/docklog.py
--- a/tortoisehg/hgqt/docklog.py Thu Mar 05 19:57:54 2026 +0100
+++ b/tortoisehg/hgqt/docklog.py Thu Mar 05 19:58:41 2026 +0100
@@ -499,7 +499,7 @@

def _runextcommand(self, cmdline):
self._extproc.setWorkingDirectory(self._workingDirectory())
- self._extproc.start(cmdline, QIODevice.OpenModeFlag.ReadOnly)
+ self._extproc.start(cmdline, mode=QIODevice.OpenModeFlag.ReadOnly)

def _cmd_hg(self, args):
self.closePrompt()

Yuya Nishihara

unread,
Mar 7, 2026, 5:46:47 AM (3 days ago) Mar 7
to Peter Demcak, thg...@googlegroups.com
On Fri, 06 Mar 2026 20:38:10 +0100, Peter Demcak wrote:
> # HG changeset patch
> # User Peter Demcak <majs...@gmail.com>
> # Date 1772737121 -3600
> # Thu Mar 05 19:58:41 2026 +0100
> # Node ID 4ff067cd6020d6635b8237f57912512d9feb0482
> # Parent d4ed04c8da7120737437170dea6c3aed83978ae8
> docklog: fix QProcess.start() call for PyQt6 compatibility

Queued this, thanks.
Reply all
Reply to author
Forward
0 new messages