Tortoise 6.5.x and mercurial_keyring bug

[Sandro Magi]

Hello all, not sure if I should post bugs here, but I can no longer pull using Pageant as an authentication method after upgrading to 6.5.1. I tried the other 6.5.x releases as well. The issue seems to be mercurial_keyring, as this is the error shown in the log:

  TypeError: safebranchrevs() got an unexpected keyword argument 'remotehidden'

I had recorded the full log but lost the message when I had to restart while downgrading back to 6.4.5 so I could get back to work.

Sandro

[Matt Harbison]

The bug tracker is: https://foss.heptapod.net/mercurial/tortoisehg/thg/-/issues if you have an account.

The stacktrace would help because the logic that blames extensions for a crash starts with extensions that don't declare they're compatible with the current version of hg.  A quick search of the mercurial_keyring code doesn't have any hits on safebranchrev.  I'd suggest disabling all 3rd party extension listed in `hg version -v`.  If that fixes it, start adding them back.  If it doesn't, start removing bundled extensions.

[Sandro Magi]

I had cause to try the newest version again, and the issue appears to be with the hg-git extension. If I disable it then pull/push works as expected. With the extension enabled I get the following error trace which seems to incorrectly attribute the problem to mercurial_keyring:

** Unknown exception encountered with possibly-broken third-party extension "mercurial_keyring" unknown
** which supports versions unknown of Mercurial.
** Please disable "mercurial_keyring" and try your action again.
** If that fixes the bug please report it to https://foss.heptapod.net/mercurial/mercurial_keyring/issues
** Python 3.9.13 (tags/v3.9.13:6de2ca5, May 17 2022, 16:36:42) [MSC v.1929 64 bit (AMD64)]
** Mercurial Distributed SCM (version 6.5.1)
** Extensions loaded: convert, hggit 1.0.2 (dulwich 0.21.3), mercurial_keyring unknown, strip, tortoisehg.util.hgcommands 6.5.1, tortoisehg.util.hgdispatch 6.5.1, tortoisehg.util.partialcommit 6.5.1, tortoisehg.util.pipeui 6.5.1, tortoisehg.util.win32ill 6.5.1, transplant
** Unknown exception encountered with possibly-broken third-party extension "mercurial_keyring" unknown
** which supports versions unknown of Mercurial.
** Please disable "mercurial_keyring" and try your action again.
** If that fixes the bug please report it to https://foss.heptapod.net/mercurial/mercurial_keyring/issues
** Python 3.9.13 (tags/v3.9.13:6de2ca5, May 17 2022, 16:36:42) [MSC v.1929 64 bit (AMD64)]
** Mercurial Distributed SCM (version 6.5.1)
** Extensions loaded: convert, hggit 1.0.2 (dulwich 0.21.3), mercurial_keyring unknown, strip, tortoisehg.util.hgcommands 6.5.1, tortoisehg.util.hgdispatch 6.5.1, tortoisehg.util.partialcommit 6.5.1, tortoisehg.util.pipeui 6.5.1, tortoisehg.util.win32ill 6.5.1, transplant
Traceback (most recent call last):
  File "hg", line 58, in <module>
  File "mercurial\dispatch.pyc", line 143, in run
  File "mercurial\dispatch.pyc", line 232, in dispatch
  File "mercurial\dispatch.pyc", line 276, in _rundispatch
  File "mercurial\dispatch.pyc", line 457, in _runcatch
  File "mercurial\dispatch.pyc", line 467, in _callcatch
  File "mercurial\scmutil.pyc", line 153, in callcatch
  File "mercurial\dispatch.pyc", line 447, in _runcatchfunc
  File "mercurial\dispatch.pyc", line 1272, in _dispatch
  File "mercurial\dispatch.pyc", line 905, in runcommand
  File "mercurial\dispatch.pyc", line 1284, in _runcommand
  File "mercurial\dispatch.pyc", line 1270, in <lambda>
  File "mercurial\util.pyc", line 1881, in check
  File "mercurial\commands.pyc", line 6696, in serve
  File "mercurial\server.pyc", line 166, in runservice
  File "mercurial\commandserver.pyc", line 461, in run
  File "mercurial\commandserver.pyc", line 395, in serve
  File "mercurial\commandserver.pyc", line 369, in serveone
  File "mercurial\commandserver.pyc", line 350, in runcommand
  File "mercurial\commandserver.pyc", line 289, in _dispatchcommand
  File "mercurial\dispatch.pyc", line 232, in dispatch
  File "mercurial\dispatch.pyc", line 276, in _rundispatch
  File "mercurial\dispatch.pyc", line 457, in _runcatch
  File "mercurial\dispatch.pyc", line 467, in _callcatch
  File "mercurial\scmutil.pyc", line 153, in callcatch
  File "mercurial\dispatch.pyc", line 447, in _runcatchfunc
  File "tortoisehg\util\hgdispatch.pyc", line 27, in _dispatch
  File "mercurial\dispatch.pyc", line 1272, in _dispatch
  File "mercurial\dispatch.pyc", line 905, in runcommand
  File "mercurial\dispatch.pyc", line 1284, in _runcommand
  File "mercurial\dispatch.pyc", line 1270, in <lambda>
  File "mercurial\util.pyc", line 1881, in check
  File "mercurial\commands.pyc", line 5475, in pull

TypeError: safebranchrevs() got an unexpected keyword argument 'remotehidden'

--
You received this message because you are subscribed to a topic in the Google Groups "TortoiseHg Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/thg-dev/6Cjx51n6uGQ/unsubscribe.
To unsubscribe from this group and all its topics, send an email to thg-dev+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/thg-dev/29c78ef3-fedc-43d7-8ba6-09378679129bn%40googlegroups.com.

[Matt Harbison]

Can you try 6.6.3?  There's a new version of hg-git bundled with it, and this error looks vaguely familiar.

[Sandro Magi]

That seemed to clear it up, so it's resolved in the new release. Thanks!

To view this discussion on the web visit https://groups.google.com/d/msgid/thg-dev/22029bfe-5d35-4da6-98a0-e623d804ad0an%40googlegroups.com.