[PATCH] settings: fix a bytes/str mismatch that prevented extension panels from showing

2 views
Skip to first unread message

Matt Harbison

unread,
Jun 30, 2022, 12:25:37 PM6/30/22
to thg...@googlegroups.com
# HG changeset patch
# User Matt Harbison <matt_h...@yahoo.com>
# Date 1656606274 14400
# Thu Jun 30 12:24:34 2022 -0400
# Branch stable
# Node ID 5c25000bc771b9678143d95c5182a3faaba1d802
# Parent 20c5fa80ce9172f9635233215664c60cc3847283
settings: fix a bytes/str mismatch that prevented extension panels from showing

A handful of extension specific items (like largefiles and reviewboard) are only
added to the selectable list of things that can be configured if the supporting
extension is enabled.

diff --git a/tortoisehg/hgqt/settings.py b/tortoisehg/hgqt/settings.py
--- a/tortoisehg/hgqt/settings.py
+++ b/tortoisehg/hgqt/settings.py
@@ -106,7 +106,7 @@

def hasExtension(extname):
for name, module in extensions.extensions():
- if name == extname:
+ if hglib.tounicode(name) == extname:
return True
return False

Yuya Nishihara

unread,
Jun 30, 2022, 9:36:27 PM6/30/22
to Matt Harbison, thg...@googlegroups.com
Queued for stable, thanks.
Reply all
Reply to author
Forward
0 new messages