Package Proposal: OAuth2 Vkontakte

[Victor Bocharsky]

Hey there!

I'm going to create a new OAuth 2 library for popular social network Vkontakte , which will base on your cool league/oauth2-client.

I'm wondering could I create this package under your `league` namespace from scratch and develop it in the thephpleague on GitHub?

Or should I create it under my own namespace first and then somehow transfer it to the league namespace when it will be finished if it possible?

Anyway, I would like to make this library a part of ThePhpLeague and maintain it under this namespace.

Thanks for your answer in advance!

Cheers!

[Woody Gilk]

There is already an OAuth2 provider here https://github.com/j4k/oauth2-vkontakte


--
Woody Gilk
http://about.me/shadowhand

> --
> You received this message because you are subscribed to the Google Groups
> "thephpleague" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to thephpleague...@googlegroups.com.
> To post to this group, send email to thephp...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/thephpleague/da1f051a-385d-47f3-bf3c-cd8f6409e938%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[Phil Sturgeon]

Although woody is responding in a bit of a curt and dismissive fashion, I'd probably agree that a provider is not something that needs to be a league package.

While I don't normally like slippery slope arguments, I feel confident from experience that if we add one others will expect theirs to be added. Suddenly we'll have a whole load of Bing/Google/Foo packages for just oauth2, all of which could have been something else.

I'd like to see the providers well maintained and up to date of course, so maybe something could be worked out. Instead of official providers vs third party providers, could there be some semi-official type of provider where there's at least one league member with access to the package but the maintainer is a community member like yourself?

--
Phil Sturgeon

> To view this discussion on the web visit https://groups.google.com/d/msgid/thephpleague/CAGOJM6%2Bwuk8U7tZ2sOiEj4V4TBLHYMWUazCJLkEZModLFVWkDA%40mail.gmail.com.

[Barry vd. Heuvel]

I feel the same way. We currently have the same 'issue' with Omnipay. There are a lot of community gateways in League repositories, but not actively maintained/used by Omnipay maintainers. This leads to a false sense of 'officially maintained gateways', while this might not be the case.

What could help is perhaps some indication of quality, eg 'Verified' packages (or semi-official, as Phil called it), which are verified to work by one of the maintainers, have a good test coverage, uses the latest version etc. Would still be more work, but not as much as 'official'  packages.

Barry

Op zaterdag 16 juli 2016 20:55:57 UTC+2 schreef Phil Sturgeon:

[Woody Gilk]

The league/oauth2-client team used to have many "official" providers
but decided that ensuring they were maintained to League standards was
extremely difficult. Hence, the oauth2-client team reduced the list to
a few very popular packages (Google, Github, Facebook, etc) and choose
to keep a list of 3rd party packages.

I personally do not want us to get back into that situation and
attaching the League name to a package that is maintained by someone
who is a not League member is a slippery slope for quality.

Is there a middle ground somewhere that would make it easier to handle
situations like this?

--
Woody Gilk
http://about.me/shadowhand

[Victor Bocharsky]

Hey Woody,

Thanks for the link! I didn't find a topic about that on your Google group and somehow missed that on GitHub, maybe because this package wasn't so popular on GitHub.

I don't want to recreate existent packages, but have a good maintenance for them would be great! That's why I agree with Phil's thoughts about it.

[Barry vd. Heuvel]

Hey Victor,

The packages aren't listed on the Github readme, but you can find them in the docs: http://oauth2-client.thephpleague.com/providers/thirdparty/

Op zaterdag 16 juli 2016 23:10:12 UTC+2 schreef Victor Bocharsky:

[Victor Bocharsky]

Hey Barry,

Good to know, thank you for this link!