League stance on HHVM support
17 views
Skip to first unread message
Ben Ramsey
Jan 12, 2018, 10:22:25 PM1/12/18
to The PHP League
Many projects have moved away from official support for HHVM, since HHVM no longer maintains feature parity with PHP 7. What is the League's official stance on HHVM support in our packages? Do we have one?
For reference, I opened this PR on league/oauth2-client:
https://github.com/thephpleague/oauth2-client/pull/682
Cheers,
Ben
For reference, I opened this PR on league/oauth2-client:
https://github.com/thephpleague/oauth2-client/pull/682
Cheers,
Ben
Phil Bennett
Jan 13, 2018, 1:34:35 AM1/13/18
to Ben Ramsey, The PHP League
I don’t think we have an official stance, for my projects I’ve been removing HHVM support as I build out the next major versions that move to PHP 7.
I would say that technically, removing HHVM is a breaking change so it should be addressed in the same way for all, being that all next major versions of our projects should be aiming at PHP 7, they should also be removing HHVM at that point.
Cheers,
Phil
Sent from my iPhone
> --
> You received this message because you are subscribed to the Google Groups "thephpleague" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to thephpleague...@googlegroups.com.
> To post to this group, send email to thephp...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/thephpleague/879EF8E9-9BA6-4E7E-9341-6C8D9A9D5106%40benramsey.com.
> For more options, visit https://groups.google.com/d/optout.
I would say that technically, removing HHVM is a breaking change so it should be addressed in the same way for all, being that all next major versions of our projects should be aiming at PHP 7, they should also be removing HHVM at that point.
Cheers,
Phil
Sent from my iPhone
> You received this message because you are subscribed to the Google Groups "thephpleague" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to thephpleague...@googlegroups.com.
> To post to this group, send email to thephp...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/thephpleague/879EF8E9-9BA6-4E7E-9341-6C8D9A9D5106%40benramsey.com.
> For more options, visit https://groups.google.com/d/optout.
Colin O'Dell
Jan 13, 2018, 9:30:36 AM1/13/18
to Phil Bennett, Ben Ramsey, The PHP League
Yeah I don't think we have an official stance.
HHVM only accounts for 0.28% of package installs on Packagist (https://seld.be/notes/php-versions-stats-2017-2-edition), so for me the question is whether it's worthwhile to support such a tiny percentage of users. I personally don't mind testing against HHVM as long as the builds pass and the code doesn't require breaking changes, performance hits, or significant effort to stay compatible.
Cheers,
Colin
To view this discussion on the web visit https://groups.google.com/d/msgid/thephpleague/9CCADC2A-C6C9-4C2F-86D3-24C976701884%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
--
Colin O'Dell
Reply all
Reply to author
Forward
0 new messages