Interim support to make VT100 a little more usable (issue 6446130)

[jas...@gmail.com]

Reviewers: mzero, thecomfyshell_googlegroups.com,

Description:
One of the pain points I found using plush day to day is how jarring the
vt100 is. Till I finish fixing it, I think this trivial change makes it
a little more bearable.

* display the command after the vt100 term instead of overlapping it
* don't remove vt100 output

Please review this at http://codereview.appspot.com/6446130/

Affected files:
M static/css/plush.css
M static/js/jobs.js


Index: static/css/plush.css
diff --git a/static/css/plush.css b/static/css/plush.css
index
064d4e76ff5b6e73d825ed462f5a7ffcf52fec5d..26153f92721933e71f6d537cb7f8379cf0301157
100644
--- a/static/css/plush.css
+++ b/static/css/plush.css
@@ -506,9 +506,13 @@ h1,h2,h3,h4,blockquote,q,.maia-nav ul {
}

.job .output {
+ position: relative;
padding: 0.25em 0 0.25em 1em;
border-right: none;
}
+.job .vtoutput {
+ padding: 0 0 0 0;
+}
.job .stdout {
color: #3f3f3f;
}
Index: static/js/jobs.js
diff --git a/static/js/jobs.js b/static/js/jobs.js
index
b38a7e9b594fea6e5a59b6ba23f7b782c316e5b2..d6a3b75d91c2b3b2d3bfaaa6d47e8eb183659191
100644
--- a/static/js/jobs.js
+++ b/static/js/jobs.js
@@ -306,6 +306,7 @@ define(['jquery', 'hterm'], function($){
removeInput();
var where = output.find('.output');
if (where.length != 1) { return; }
+ where.addClass('vtoutput');
var node = $('<div></div>', { 'class': 'terminal' })
node.appendTo(where);
var term = new hterm.Terminal();
@@ -327,9 +328,8 @@ define(['jquery', 'hterm'], function($){
function removeVTOutput() {
if (terminal) {
terminal.uninstallKeyboard();
+ terminal.setCursorVisible(false);
terminal = null;
- terminalNode.remove();
- terminalNode = null;
}
};

[ma...@glyphic.com]

LGTM

http://codereview.appspot.com/6446130/