Alias support ... review request

7 views
Skip to first unread message

Mark Lentczner

unread,
Nov 21, 2012, 1:59:04 PM11/21/12
to thecom...@googlegroups.com
I've got alias support pretty much done. Pull request, if anyone would like to code review before I commit to main: https://github.com/mzero/plush/pull/19

The aliases.doctest file is full of some hilarity of how aliases work.

Still left to do is: Aliases throw all the annotations off as the character positioning information is wrong (it is post-aliasing, but the user sees the unaliased command line), and there is no annotation information on the aliasing itself. I should have both of these done tonight in another change set.

- Mark

Mark Lentczner

unread,
Nov 24, 2012, 12:46:26 PM11/24/12
to thecom...@googlegroups.com
I updated this code a bit - and rebased, so here is a new pull request for it: https://github.com/mzero/plush/pull/20   -- code reviews welcome before I commit to master (tomorrow evening?)

- Mark

Reply all
Reply to author
Forward
0 new messages