Re: job topics (issue 6452059)

9 views
Skip to first unread message

jas...@gmail.com

unread,
Jul 30, 2012, 2:55:14 AM7/30/12
to mz...@google.com, thecom...@googlegroups.com, re...@codereview-hr.appspotmail.com
LGTM


http://codereview.appspot.com/6452059/diff/1/static/js/jobs.js
File static/js/jobs.js (right):

http://codereview.appspot.com/6452059/diff/1/static/js/jobs.js#newcode77
static/js/jobs.js:77: var nextTopic = currentTopic;
Recommend not masking the function name with a variable here.

http://codereview.appspot.com/6452059/diff/1/static/js/jobs.js#newcode366
static/js/jobs.js:366: keydown: keydown,
extraneous comma

http://codereview.appspot.com/6452059/diff/1/static/js/shell.js
File static/js/shell.js (right):

http://codereview.appspot.com/6452059/diff/1/static/js/shell.js#newcode249
static/js/shell.js:249: if (cmd !== '') {
Perhaps cmd.trim() !== ''

http://codereview.appspot.com/6452059/
Reply all
Reply to author
Forward
0 new messages