Sane Builtins - Haskell Code Review wanted

10 views
Skip to first unread message

mzero

unread,
Dec 14, 2012, 11:19:03 PM12/14/12
to thecom...@googlegroups.com
Note about these pull requests: I put these out there, as I think it is good practice to have a second pair of eyes over the code. On the other hand, I realize that at present that we don't have too many eyeballs, or time. Hence, I generally put them out there for a few days, and then, merge 'em in. But, I'm happy for your comments.

make some builtins only available in test mode, and have them act as executables

The effect of this change is that our half-implementations of things like fgrep, touch, etc... will no longer be "builtins" under normal operation.
These utilities are required so that we can run our doctest suite under test mode. Now they appear as executables in test mode (under /bin).

https://github.com/mzero/plush/pull/23
 

Warren Harris

unread,
Dec 16, 2012, 9:01:40 AM12/16/12
to thecom...@googlegroups.com

Hey Mark

I'm traveling right now but I'll try to take a look at this when I get back.

Warren

--
You received this message because you are subscribed to the Google Groups "Plush - the comfy shell" group.
To post to this group, send email to thecom...@googlegroups.com.
To unsubscribe from this group, send email to thecomfyshel...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msg/thecomfyshell/-/EqzSxLOwmhEJ.
For more options, visit https://groups.google.com/groups/opt_out.
 
 
Reply all
Reply to author
Forward
0 new messages