[Theano/Theano] ef9754: use string_types instead of str in get_substream_r...

0 views
Skip to first unread message

Frédéric Bastien

unread,
Sep 13, 2019, 2:29:08 PM9/13/19
to theano...@googlegroups.com
Branch: refs/heads/master
Home: https://github.com/Theano/Theano
Commit: ef975430cdebdbd477a871302301be6526b03c21
https://github.com/Theano/Theano/commit/ef975430cdebdbd477a871302301be6526b03c21
Author: Tim O'Donnell <timod...@gmail.com>
Date: 2019-09-06 (Fri, 06 Sep 2019)

Changed paths:
M theano/sandbox/rng_mrg.py

Log Message:
-----------
use string_types instead of str in get_substream_rstates dtype assertion

Using Theano 1.0.4 via Keras 2.2.5 under Python 2.7.12, calling `keras.model.model_from_json()` for model deserialization fails at this assertion in theano at `get_substream_rstates` because `json.loads()` as called by Keras is returning a dict with unicode objects as values. This PR fixes the problem.


Commit: 8f510a1f00dfbe6d6dd665d67329874c24fd09c5
https://github.com/Theano/Theano/commit/8f510a1f00dfbe6d6dd665d67329874c24fd09c5
Author: Frédéric Bastien <frederic...@gmail.com>
Date: 2019-09-13 (Fri, 13 Sep 2019)

Changed paths:
M theano/sandbox/rng_mrg.py

Log Message:
-----------
Merge pull request #6718 from timodonnell/patch-1

use string_types instead of str in get_substream_rstates dtype assertion


Compare: https://github.com/Theano/Theano/compare/3be13b255a20...8f510a1f00df
Reply all
Reply to author
Forward
0 new messages