[TxMt] [TM2] Selection color changes

23 views
Skip to first unread message

J.Jeising

unread,
Feb 20, 2012, 10:56:39 AM2/20/12
to text...@lists.macromates.com
In #9064 (Mac OS X 10.6.8) the selection highlight color gets more transparent (?) sometimes. After focussing TextMate 2 the color is correct, when changing to another Tab, the color changes. If you go back to your original tab it shows the same lighter color there to.
When you focus another application and go back to TextMate it shows the original (more opaque) color again.

Regards
Jannes

correct.png
false.png

Allan Odgaard

unread,
Feb 20, 2012, 7:38:32 PM2/20/12
to TextMate users
On 20/02/2012, at 22.56, J.Jeising wrote:

> In #9064 (Mac OS X 10.6.8) the selection highlight color gets more transparent (?) sometimes […]

Yes, it dims the selection when focus is not in the text view. This was the same for previous builds and TextMate 1.x.


_______________________________________________
textmate mailing list
text...@lists.macromates.com
http://lists.macromates.com/listinfo/textmate

Thomas Krajacic

unread,
Feb 21, 2012, 10:38:07 AM2/21/12
to TextMate users
I think TM sometimes forgets to cancel the dimming when it comes back to the foreground or simply applies it erroneously.
Or it is a different bug.

I have created a variation of the twilight theme with a stronger selection color (basically a lighter grey).
Quite often though it doesn't show, but rather the dark original color is shown. I fix it by going back to the bundle editor and just viewing my theme there and closing the bundle editor again corrects the display in the regular window.

Not sure if Textmate dims my custom theme and it just looks like the original theme, or the custom theme does not get even applied even though it is chosen in the view menu (But then viewing my altered theme in the bundle editor wouldn't make a difference I guess).

cheers,
Thomas

Steve King

unread,
Feb 21, 2012, 2:55:29 PM2/21/12
to text...@lists.macromates.com
On 2012-02-21 10:38, Thomas Krajacic wrote:
> I think TM sometimes forgets to cancel the dimming when it comes back to the foreground or simply applies it erroneously.

I've noticed this as well, and TM2 is definitely behaving differently
from TM1. In TM1 I could do a search in one tab, switch to a second
tab, then switch back and the search term would still be brightly
highlighted. In TM2 I do the same thing, but the search term is dimmed
when I get back to the first tab. I only get the bright highlight again
if I give focus to another app, then focus TM2 again.

--
Steve King
Sr. Software Engineer
Arbor Networks
+1 734 821 1461
www.arbornetworks.com <http://www.arbornetworks.com/>

Allan Odgaard

unread,
Feb 26, 2012, 7:31:02 PM2/26/12
to TextMate users
On 21/02/2012, at 22.38, Thomas Krajacic wrote:

> I think TM sometimes forgets to cancel the dimming when it comes back to the foreground or simply applies it erroneously.
> Or it is a different bug.

Let me know if it happens in r9090 (current nightly build) — I didn’t find any bugs but I changed the code involved.

> […] I fix it by going back to the bundle editor and just viewing my theme there and closing the bundle editor again corrects the display in the regular window.

Most likely what is fixing it is just the extra “window activated” event which is sent when the bundle editor is closed (which cause selection to be redrawn).

Keith Solomon

unread,
Feb 26, 2012, 7:53:47 PM2/26/12
to TextMate users
On 2/26/12 6:31 PM, Allan Odgaard wrote:
> Let me know if it happens in r9090 (current nightly build) — I didn’t
> find any bugs but I changed the code involved.
There is one instance where I see erroneous highlighting still being
applied in r9090...if I highlight some text, switch to another tab (in
TM) and switch back, the highlight is still dimmed. If I switch to
another application, the highlight comes back like it should.

--
Keith Solomon - ksol...@gmail.com
My Blog - http://reciprocity.be/
My Flickr - http://www.flickr.com/photos/zarath0s/

Thomas Krajacic

unread,
Feb 26, 2012, 7:54:44 PM2/26/12
to TextMate users
The bug still appears, when switching to another open tab.

To reproduce:
Switching back to Textmate from another application restores the correct highlighting, but when switching document tabs, they remain dimmed.

Hope this helps.


BTW
Keep up the great work!
TM2 already is amazing and I am sure it will be even better once you implement all the stuff you have probably planned
and the abundance of tiny bugs is squashed.

Cheers,
Thomas

Allan Odgaard

unread,
Feb 26, 2012, 11:03:23 PM2/26/12
to TextMate users
On 27/02/2012, at 07.54, Thomas Krajacic wrote:

> To reproduce:
> Switching back to Textmate from another application restores the correct highlighting, but when switching document tabs, they remain dimmed.

Thanks — r9092 (available as test build ATM) should fix this.

J.Jeising

unread,
Mar 25, 2012, 6:00:45 PM3/25/12
to TextMate users
Allan Odgaard wrote:
> On 27/02/2012, at 07.54, Thomas Krajacic wrote:
>> To reproduce:
>> Switching back to Textmate from another application restores the correct highlighting, but when switching document tabs, they remain dimmed.
>
> Thanks — r9092 (available as test build ATM) should fix this.

Fixed for me (using r9100), thank you.

Regards
Jannes

Reply all
Reply to author
Forward
0 new messages