Bugfixes of testoob (newline for skipped, multithreaded coverage)

14 views
Skip to first unread message

Ronnie van 't Westeinde

unread,
Oct 31, 2010, 4:29:56 AM10/31/10
to Testoob
Hi Ori and all,

I've made two fixes, which are available on a launchpad branch:

1) Newline issues in case of skipped testcases were introduced in the
previous
version, in case of verbose output. I've fixed it so that it works
with both testcases
that are skipped programatically, as well as those that are
skipped because of a
keyboard interrupt.
This fix is available in https://code.launchpad.net/~rwestein/testoob/skip_newline

2) The --coverage option only took the mail thread into account, and
not any other
threads that were spawned. This change fixes that:
lp:~rwestein/testoob/multithreaded_coverage

Can you please have a look at these changes and integrate them in the
main branch
of testoob?

Kind regards,
Ronnie

Ori Peleg

unread,
Oct 31, 2010, 5:06:07 AM10/31/10
to testoob
Sure Ronnie, I'll pull your changes from Launchpad.

BTW - I started moving Testoob to GitHub, mostly because I have trouble with Launchpad's UI.
If you're okay with git and GitHub, you can make future changes there:


--
You received this message because you are subscribed to the Google Groups "Testoob" group.
To post to this group, send email to tes...@googlegroups.com.
To unsubscribe from this group, send email to testoob+u...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/testoob?hl=en.




--
Check out my blog: http://orip.org

Ronnie van 't Westeinde

unread,
Oct 31, 2010, 6:24:31 AM10/31/10
to Testoob
Ori,

Thanks. I have no problem moving over to git and GitHub. I'll play
around with it a bit,
and I'll try to get the next fix in git. (I'm currently working on a
small fix (to integrate the
use of unittest.skipTest of python 2.7) which is an excellent testcase
for a new version
control system. I'll let you know if I get stuck ;-)

Ronnie
> > testoob+u...@googlegroups.com<testoob%2Bunsu...@googlegroups.com >
> > .

Ronnie van 't Westeinde

unread,
Oct 31, 2010, 8:39:19 AM10/31/10
to Testoob
Ori,

I've played around a bit with git, and committed and pushed changes to
the github
archive. Those changes are needed to get the testoob tests to pass on
Python 2.7
Can you verify if you can see those changes and include those in the
main branch
as well (if you agree with them, of course)

Ronnie

On 31 okt, 11:24, "Ronnie van 't Westeinde"

Ori Peleg

unread,
Jan 23, 2011, 9:32:23 AM1/23/11
to tes...@googlegroups.com
Took me a while :-/
Can you take a look at the 1.16_candidate branch I pushed to github to review them?

thanks

To unsubscribe from this group, send email to testoob+u...@googlegroups.com.

For more options, visit this group at http://groups.google.com/group/testoob?hl=en.

Reply all
Reply to author
Forward
0 new messages