--stop_on_fail option stops on a skipped testcase

[Ronnie van 't Westeinde]

Hi all,

I run into the issue that the --stop_on_fail option stops also when a
skipped
testcase is encountered. Is this intentional?
It would be easier to use when --stop_on_fail simply skips the skipped
testcases,
and stops when the first actually failed testcase is encountered.

If you agree with this change in functionality of the --stop_on_fail
option, I'll
implement it.

Regards,
Ronnie

[Ori Peleg]

It's a bug :)

Your suggestion sounds great.

--
Check out my blog: http://orip.org

[Ronnie van 't Westeinde]

It turned out the bug was caused because the isSuccessful() method was
used to determine
if it was necessary to stop. If the very first testcase was skipped,
isSuccessful() returns False,
which caused the execution to stop.
I've added isFailed to the reporters and use that as return value of
the run() method of the runner.
I've left the original isSuccessful intact, to make sure that the end
result of a test run with only
skipped testcases stays failed.

I've pushed the changes into lp:~rwestein/testoob/stop-on-
fail_after_skip

Please have a look at it.

Ronnie

On Mar 15, 8:46 am, Ori Peleg <ori...@gmail.com> wrote:
> It's a bug :)Your suggestion sounds great.

[Ori Peleg]

Cool, I'll have a look.

[Ori Peleg]

Looks great. Merged to trunk.