IAnnotationTransformer gets invoked once per multiple listeners

[Vineet Duggal]

I have IAnnotationTransformer implemented in two listeners. Using both these listeners together only one of the IAnnotationTransformer implementation is invoked.
Is it expected?

[⇜Krishnan Mahadevan⇝]

Hard to say. 

Do you have a simple standalone to share that can demonstrate the issue ?

Also please ensure you are using TestNG 6.14.3 ( latest released version as of today) 

On Thu 9 Aug, 2018, 23:22 Vineet Duggal, <vineet...@gmail.com> wrote:

I have IAnnotationTransformer implemented in two listeners. Using both these listeners together only one of the IAnnotationTransformer implementation is invoked.
Is it expected?

--
You received this message because you are subscribed to the Google Groups "testng-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to testng-users...@googlegroups.com.
To post to this group, send email to testng...@googlegroups.com.
Visit this group at https://groups.google.com/group/testng-users.
For more options, visit https://groups.google.com/d/optout.

--

Thanks & Regards
Krishnan Mahadevan

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"
My Scribblings @ http://wakened-cognition.blogspot.com/

My Technical Scribbings @ http://rationaleemotions.wordpress.com/

[Vineet Duggal]

attaching the zip with the standalone testcase

demoisue.xml has two listeners configured;

when the tests are run only the second listener in the sequence is executed with the following message:

[TestNG] [WARN] AnnotationTransformer already set

In Transform Listener2

In sampleTest

Thanks

Vineet

[⇜Krishnan Mahadevan⇝]

You haven't told us what version you are working with. If you aren't on the latest version, please ensure you are using TestNG 6.14.3

Thanks & Regards
Krishnan Mahadevan

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"
My Scribblings @ http://wakened-cognition.blogspot.com/

My Technical Scribblings @ http://rationaleemotions.wordpress.com/

On Fri, Aug 10, 2018 at 10:04 AM, Vineet Duggal <vineet...@gmail.com> wrote:

attaching the zip with the standalone testcase

demoisue.xml has two listeners configured;

when the tests are run only the second listener in the sequence is executed with the following message:

[TestNG] [WARN] AnnotationTransformer already set

In Transform Listener2

In sampleTest

Thanks

Vineet

On Thu, Aug 9, 2018 at 11:24 PM ⇜Krishnan Mahadevan⇝ <krishnan.mahadevan1978@gmail.com> wrote:

Hard to say. 

Do you have a simple standalone to share that can demonstrate the issue ?

Also please ensure you are using TestNG 6.14.3 ( latest released version as of today) 

On Thu 9 Aug, 2018, 23:22 Vineet Duggal, <vineet...@gmail.com> wrote:

I have IAnnotationTransformer implemented in two listeners. Using both these listeners together only one of the IAnnotationTransformer implementation is invoked.
Is it expected?

--
You received this message because you are subscribed to the Google Groups "testng-users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to testng-users+unsubscribe@googlegroups.com.

To post to this group, send email to testng...@googlegroups.com.
Visit this group at https://groups.google.com/group/testng-users.
For more options, visit https://groups.google.com/d/optout.

--

Thanks & Regards
Krishnan Mahadevan

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"
My Scribblings @ http://wakened-cognition.blogspot.com/

My Technical Scribbings @ http://rationaleemotions.wordpress.com/

--
You received this message because you are subscribed to the Google Groups "testng-users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to testng-users+unsubscribe@googlegroups.com.

To post to this group, send email to testng...@googlegroups.com.
Visit this group at https://groups.google.com/group/testng-users.
For more options, visit https://groups.google.com/d/optout.

--

You received this message because you are subscribed to the Google Groups "testng-users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to testng-users+unsubscribe@googlegroups.com.

[Vineet Duggal]

Tested with 16.4.3 as you had suggested

Thanks

Vineet

On Fri, Aug 10, 2018 at 10:06 AM ⇜Krishnan Mahadevan⇝ <krishnan.ma...@gmail.com> wrote:

You haven't told us what version you are working with. If you aren't on the latest version, please ensure you are using TestNG 6.14.3

Thanks & Regards
Krishnan Mahadevan

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"
My Scribblings @ http://wakened-cognition.blogspot.com/

My Technical Scribblings @ http://rationaleemotions.wordpress.com/

On Fri, Aug 10, 2018 at 10:04 AM, Vineet Duggal <vineet...@gmail.com> wrote:

attaching the zip with the standalone testcase

demoisue.xml has two listeners configured;

when the tests are run only the second listener in the sequence is executed with the following message:

[TestNG] [WARN] AnnotationTransformer already set

In Transform Listener2

In sampleTest

Thanks

Vineet

On Thu, Aug 9, 2018 at 11:24 PM ⇜Krishnan Mahadevan⇝ <krishnan.ma...@gmail.com> wrote:

Hard to say. 

Do you have a simple standalone to share that can demonstrate the issue ?

Also please ensure you are using TestNG 6.14.3 ( latest released version as of today) 

On Thu 9 Aug, 2018, 23:22 Vineet Duggal, <vineet...@gmail.com> wrote:

I have IAnnotationTransformer implemented in two listeners. Using both these listeners together only one of the IAnnotationTransformer implementation is invoked.
Is it expected?

--
You received this message because you are subscribed to the Google Groups "testng-users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to testng-users...@googlegroups.com.

To post to this group, send email to testng...@googlegroups.com.
Visit this group at https://groups.google.com/group/testng-users.
For more options, visit https://groups.google.com/d/optout.

--

Thanks & Regards
Krishnan Mahadevan

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"
My Scribblings @ http://wakened-cognition.blogspot.com/

My Technical Scribbings @ http://rationaleemotions.wordpress.com/

--
You received this message because you are subscribed to the Google Groups "testng-users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to testng-users...@googlegroups.com.

To post to this group, send email to testng...@googlegroups.com.
Visit this group at https://groups.google.com/group/testng-users.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "testng-users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to testng-users...@googlegroups.com.

To post to this group, send email to testng...@googlegroups.com.
Visit this group at https://groups.google.com/group/testng-users.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "testng-users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to testng-users...@googlegroups.com.

[Krishnan Mahadevan]

Vineet,

From the codebase, it looks like TestNG was not designed to work with multiple AnnotationTransformers.

AnnotationTransformers were always expected to be only 1.

That is why, TestNG just honours the last one that got injected.

I don’t know what should the expected behavior be and it perhaps would need some discussion on what should be the expected behavior.

 

I would suggest that you please file a bug here: https://github.com/cbeust/testng/issues

 

Just curious: Why do you have multiple annotation transformers in place ?

 

Thanks & Regards

Krishnan Mahadevan

 

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"

My Scribblings @ http://wakened-cognition.blogspot.com/

My Technical Scribbings @ http://rationaleemotions.wordpress.com/

 

[Vineet Duggal]

>> Just curious: Why do you have multiple annotation transformers in place ?

We have different teams in engineering  implementing listeners specific to their requirements e.g stress/performance engineering team ; quality engineering teams etc. In this case we ran into conflict between teams using the annotation transformers 

Thanks

Vineet

[⇜Krishnan Mahadevan⇝]

You could perhaps try something like this:

1. Build a generic Annotation transformer which is Service Provider Interface aware.
   
2. Now have individual teams basically wire in their implementations via a SPI implementation that (1) understands.
3. Have the generic transformer, basically iterate through all the individual custom implementations wired in via (2) and invoke the "transform()" method one after the other.
4. Have your suite xml file refer to the generic annotation transformer created in (1) through the <listener> tag.

That should basically solve your problem.

Thanks & Regards
Krishnan Mahadevan

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"
My Scribblings @ http://wakened-cognition.blogspot.com/

My Technical Scribblings @ http://rationaleemotions.wordpress.com/

On Fri, Aug 10, 2018 at 11:36 AM, Vineet Duggal <vineet...@gmail.com> wrote:

>> Just curious: Why do you have multiple annotation transformers in place ?

We have different teams in engineering  implementing listeners specific to their requirements e.g stress/performance engineering team ; quality engineering teams etc. In this case we ran into conflict between teams using the annotation transformers 

Thanks

Vineet

To unsubscribe from this group and stop receiving emails from it, send an email to testng-users+unsubscribe@googlegroups.com.

To post to this group, send email to testng...@googlegroups.com.
Visit this group at https://groups.google.com/group/testng-users.
For more options, visit https://groups.google.com/d/optout.

--

Thanks & Regards
Krishnan Mahadevan

"All the desirable things in life are either illegal, expensive, fattening or in love with someone else!"
My Scribblings @ http://wakened-cognition.blogspot.com/

My Technical Scribbings @ http://rationaleemotions.wordpress.com/

--

You received this message because you are subscribed to the Google Groups "testng-users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to testng-users+unsubscribe@googlegroups.com.

To post to this group, send email to testng...@googlegroups.com.
Visit this group at https://groups.google.com/group/testng-users.
For more options, visit https://groups.google.com/d/optout.

--

You received this message because you are subscribed to the Google Groups "testng-users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to testng-users+unsubscribe@googlegroups.com.

To post to this group, send email to testng...@googlegroups.com.
Visit this group at https://groups.google.com/group/testng-users.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "testng-users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to testng-users+unsubscribe@googlegroups.com.

To post to this group, send email to testng...@googlegroups.com.
Visit this group at https://groups.google.com/group/testng-users.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "testng-users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to testng-users+unsubscribe@googlegroups.com.

To post to this group, send email to testng...@googlegroups.com.
Visit this group at https://groups.google.com/group/testng-users.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "testng-users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to testng-users+unsubscribe@googlegroups.com.

To post to this group, send email to testng...@googlegroups.com.
Visit this group at https://groups.google.com/group/testng-users.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "testng-users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to testng-users+unsubscribe@googlegroups.com.