Fix TODO and create code review send script
aeagl...@gmail.com
Please review this at http://codereview.appspot.com/49063
Affected files:
M core/pom.xml
A sendCodeReview.sh
Index: sendCodeReview.sh
===================================================================
--- sendCodeReview.sh (revision 0)
+++ sendCodeReview.sh (revision 0)
@@ -0,0 +1,5 @@
+#!/bin/bash
+#
+# Author: alex...@google.com (Alex Eagle)
+
+./upload.py -r aeagl...@gmail.com --cc
testability-...@googlegroups.com --send_mail
Property changes on: sendCodeReview.sh
___________________________________________________________________
Name: svn:executable
+ *
Index: core/pom.xml
===================================================================
--- core/pom.xml (revision 359)
+++ core/pom.xml (working copy)
@@ -113,41 +113,12 @@
</build>
<reporting>
<plugins>
-
- <!-- TODO: enable once the testability maven plugin is available
- <plugin>
- <groupId>com.google.testability-explorer</groupId>
- <artifactId>maven2-plugin</artifactId>
- <version>1.3.1</version>
- <configuration>
- <filter>com.google.test.metric</filter>
- <resultfile>report.xml</resultfile>
- </configuration>
- <executions>
- <execution>
- <goals>
- <goal>run</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
+ <!-- The testability explorer maven plugin cannot be used here,
because it would introduce
+ a cyclical dependency.
+ Instead, we manually run the testability plugin in the continuous
build by running
+ mvn
com.google.testability-explorer:maven-testability-plugin:testability
+ after the mvn clean install goals.
-->
-
- <!--
- <plugin>
- <groupId>emma</groupId>
- <artifactId>maven-emma-plugin</artifactId>
- <configuration>
- <filter>
- <excludes>
- <exclude>com.google.test.metric.example.*</exclude>
- <exclude>com.google.test.metric.cpp.InternalLexer</exclude>
- <exclude>com.google.test.metric.cpp.InternalParser</exclude>
- </excludes>
- </filter>
- </configuration>
- </plugin>
- -->
</plugins>
</reporting>