Re: Refactor to get model and report separately out from JavaTestabilityRunner

0 views
Skip to first unread message

aeagl...@gmail.com

unread,
May 14, 2009, 3:54:13 PM5/14/09
to shyams...@gmail.com, kslun...@gmail.com, testability-...@googlegroups.com
LGTM, couple things:


http://codereview.appspot.com/67048/diff/1/35
File src/main/java/com/google/test/metric/AnalysisModel.java (right):

http://codereview.appspot.com/67048/diff/1/35#newcode1
Line 1:
copyright on all new files

http://codereview.appspot.com/67048/diff/1/35#newcode16
Line 16:
mention that null is allowed?

http://codereview.appspot.com/67048/diff/1/13
File src/main/java/com/google/test/metric/JavaTestabilityRunner.java
(right):

http://codereview.appspot.com/67048/diff/1/13#newcode98
Line 98: e.printStackTrace();
why did the exception handling change?

http://codereview.appspot.com/67048/diff/1/36
File src/main/java/com/google/test/metric/ReportPrinterBuilder.java
(right):

http://codereview.appspot.com/67048/diff/1/36#newcode46
Line 46: public class ReportPrinterBuilder {
should probably rename to ReportGeneratorBuilder

http://codereview.appspot.com/67048/diff/1/15
File src/main/java/com/google/test/metric/report/SummaryReportModel.java
(right):

http://codereview.appspot.com/67048/diff/1/15#newcode62
Line 62: @Override
make sure this works with java5 - not an interface method?

http://codereview.appspot.com/67048

Reply all
Reply to author
Forward
0 new messages