CMD+Left arrow and CMD+Right arrow don't switch between terminal tabs anymore on OSX

[Tanel Poder]

Hi,

I downloaded the latest Terminator package for OSX (28.130.7298) and in this version CMD+Left and CMD+Right just print characters "9C" and "9C" in the terminal prompt instead of switching active tabs (screenshot attached).

Tried both with JDK 8 (191) and JDK 11. I'm using latest OSX 10.14.2. 

The previous OSX build (27.148.7060) works ok, switches tabs on CMD+Left/Right.

Looks like the latest terminfo file is in place too:

$ ls -l .terminfo/*/terminator

-rw-r--r--  1 tanel  staff  1515 Jan 11 16:17 .terminfo/74/terminator

-rw-r--r--  1 tanel  staff  1515 Jan 11 16:17 .terminfo/t/terminator

Any ideas?

Thanks,

Tanel.

[Elliott Hughes]

Unsurprisingly, I can't reproduce this on Linux so it'll have to wait until I next have some Mac access. Does the menu show the right keystroke? If not, that might (a) give you a usable workaround and (b) give us a clue about what broke...

--
You received this message because you are subscribed to the Google Groups "terminator-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to terminator-use...@googlegroups.com.
To post to this group, send email to terminat...@googlegroups.com.
Visit this group at https://groups.google.com/group/terminator-users.
For more options, visit https://groups.google.com/d/optout.

[Tanel Poder]

Yep the menu has the right shortcuts and when I click on the "Select Previous/Next Tab" in the meny with my mouse, then the tabs are correctly selected.

The menu items look like this:

I also tried adding the same shortcuts in the OSX Keyboard shortcut preferences, but they didn't help either (got the same behavior as menioned in the OP):

Interestingly, Terminator 28.130.7298 shows this in the "About Terminator" window:

Normally (in previous versions) it shows the Terminator logo and version numbers.

Thanks for your help!

Tanel.

[Elliott Hughes]

On Fri, Jan 18, 2019 at 6:48 AM Tanel Poder <ta...@poderc.com> wrote:

Yep the menu has the right shortcuts and when I click on the "Select Previous/Next Tab" in the meny with my mouse, then the tabs are correctly selected.

The menu items look like this:

I also tried adding the same shortcuts in the OSX Keyboard shortcut preferences, but they didn't help either (got the same behavior as menioned in the OP):

Interestingly, Terminator 28.130.7298 shows this in the "About Terminator" window:

Normally (in previous versions) it shows the Terminator logo and version numbers.

huh. i thought i'd tested that... i'll try to get access to a Mac over the long weekend and take a look at both problems. (plus the bits of new Mac support that are known "TODO"s...)

--

Elliott Hughes - http://www.jessies.org/~enh/

[Martin Dorey]

> I downloaded the latest Terminator package for OSX (28.130.7298)

You'd think that we'd include the git hash but no, I did the least I could possibly get away with, so .generated/build-revision.txt just says:

2018-12-22T14:22:44+00:00

7298

7298

28.130.7298

That'll have been built by Simon Crosland on a new Apple.

> The previous OSX build (27.148.7060)

.generated/build-revision.txt says:

2018-02-16T09:36:29-08:00

7060

7060

27.148.7060

Built on my old ~defunct Snow Badger Core 2 Duo MacBook.

mad@shuttle:~/jessies/work/salma-hayek/lib/build$ git rev-list HEAD | tail -7298 | head -1

8718f1c064a23b284afe51190b71ed4d38d07472

tail: error writing 'standard output': Broken pipe

mad@shuttle:~/jessies/work/salma-hayek/lib/build$ git show 8718f1c064a23b284afe51190b71ed4d38d07472

commit 8718f1c064a23b284afe51190b71ed4d38d07472

Author: Elliott Hughes <elliott....@gmail.com>

Date:   Sat Dec 22 14:31:17 2018 -0800

That's after the build date, so can't be included, so I guess the last included change was:

mad@shuttle:~/jessies/work/salma-hayek/lib/build$ git rev-list HEAD | tail -7298 | head -2

8718f1c064a23b284afe51190b71ed4d38d07472

11806067b93b5a4fd7424a90ea3bae763b731724

tail: error writing 'standard output': Broken pipe

mad@shuttle:~/jessies/work/salma-hayek/lib/build$ git show 11806067b93b5a4fd7424a90ea3bae763b731724

commit 11806067b93b5a4fd7424a90ea3bae763b731724

Author: Martin Dorey <marti...@gmail.com>

Date:   Fri Dec 21 12:09:58 2018 -0800

I don't see anything Apple-related in the changes since:

git log 11806067b93b5a4fd7424a90ea3bae763b731724..HEAD

[Elliott Hughes]

On Fri, Jan 18, 2019 at 11:31 PM Elliott Hughes <elliott....@gmail.com> wrote:

On Fri, Jan 18, 2019 at 6:48 AM Tanel Poder <ta...@poderc.com> wrote:

Yep the menu has the right shortcuts and when I click on the "Select Previous/Next Tab" in the meny with my mouse, then the tabs are correctly selected.

The menu items look like this:

TL;DR i've committed a fix for this.

the way Terminator handles keyboard shortcuts is a bit complicated. in particular, we support *lots* more shortcuts than we show, because the idea is that no matter what you're used to, your muscle memory should "just work". (that's why in the years since i last touched this code [and expressed a preference in the comments for using the arrow keys to switch tabs] i've been able to switch to the Chrome-like use of the tab key [that we already advertise in each tab's tooltip, and which continued to function as a work-around] without even noticing i had!)

anyway, this meant that we were doing some of the shortcut handling ourselves, and Java has tried to push harder for folks to switch from getModifiers (and friends) to getModifiersEx (and friends). they're being quite noisy about deprecation now, and i "fixed" this recently. it even worked on Linux. but there was one place where they deprecated the old thing even though the replacement is only available from Java 10 (which we're not yet requiring). my @SuppressWarnings works fine for Linux and Windows, but broke these kinds of shortcuts on macOS (because META_DOWN_MASK != META_MASK).

i've added a hack for now, and some day when no-one needs Java 9 or earlier we can delete it.

(i'm pretty tempted to move the publicly advertised shortcut to the tab key, since that's what Apple's Terminal uses and that's probably what 99% of folks are used to from Chrome and other browsers.)

 

I also tried adding the same shortcuts in the OSX Keyboard shortcut preferences, but they didn't help either (got the same behavior as menioned in the OP):

Interestingly, Terminator 28.130.7298 shows this in the "About Terminator" window:

Normally (in previous versions) it shows the Terminator logo and version numbers.

huh. i thought i'd tested that... i'll try to get access to a Mac over the long weekend and take a look at both problems. (plus the bits of new Mac support that are known "TODO"s...)

that's working fine for me. what version of Java do you have installed? i have `java 11.0.1 2018-10-16 LTS` but it should work with older versions too (just not _too_ old, because really old versions only have the old "eawt" stuff and new versions only have the java.awt.Desktop stuff). Help > Debugging Tools > Show Debugging Messages should let you see what we're using even if the about box isn't working for you. (i wonder if you have multiple Java versions installed and we're choosing the wrong one?)

[Tanel Poder]

Thanks Elliott, comments below:

On Monday, January 21, 2019 at 1:36:46 PM UTC-5, Elliott Hughes wrote:

(i'm pretty tempted to move the publicly advertised shortcut to the tab key, since that's what Apple's Terminal uses and that's probably what 99% of folks are used to from Chrome and other browsers.)

Yep the CMD+Tab and CMD+Shift+Tab shortcuts work (I wasn't aware of their availablity).

Interestingly, Terminator 28.130.7298 shows this in the "About Terminator" window:

Normally (in previous versions) it shows the Terminator logo and version numbers.

huh. i thought i'd tested that... i'll try to get access to a Mac over the long weekend and take a look at both problems. (plus the bits of new Mac support that are known "TODO"s...)

that's working fine for me. what version of Java do you have installed?

Indeed, I did have an "old" JDK 8_u192 around (thought I had removed it ) that got used instead of JDK 11.0.2 that I also had installed. JDK 8_u192 and _u202 both show just Java 1.0 in the about box, but JDK 11.0.2 showed the correct message in that box. So it was more of a configuration problem on my side... unfortunately I'll need JDK 8 on my OSX for a few more months (due to another app I'm using), so might stick with the old Terminator version for a bit more.

I just discovered another issue with the latest Terminator build (28.130.7298) on OSX (tested with JDK 11.0.2) - When I copy some text from Safari browser, then paste does nothing in Terminator (doesn't paste anything). At the same time I can paste the same clipboard into the native OSX Terminal.app ok. Copying/pasting from Terminator to Terminator works ok, looks like only pasting stuff from other apps doesn't... I can record a video example of this if needed.

 

[Elliott Hughes]

On Mon, Jan 21, 2019 at 3:57 PM Tanel Poder <ta...@poderc.com> wrote:

Thanks Elliott, comments below:

On Monday, January 21, 2019 at 1:36:46 PM UTC-5, Elliott Hughes wrote:

(i'm pretty tempted to move the publicly advertised shortcut to the tab key, since that's what Apple's Terminal uses and that's probably what 99% of folks are used to from Chrome and other browsers.)

Yep the CMD+Tab and CMD+Shift+Tab shortcuts work (I wasn't aware of their availablity).

Interestingly, Terminator 28.130.7298 shows this in the "About Terminator" window:

Normally (in previous versions) it shows the Terminator logo and version numbers.

huh. i thought i'd tested that... i'll try to get access to a Mac over the long weekend and take a look at both problems. (plus the bits of new Mac support that are known "TODO"s...)

that's working fine for me. what version of Java do you have installed?

Indeed, I did have an "old" JDK 8_u192 around (thought I had removed it ) that got used instead of JDK 11.0.2 that I also had installed. JDK 8_u192 and _u202 both show just Java 1.0 in the about box, but JDK 11.0.2 showed the correct message in that box. So it was more of a configuration problem on my side... unfortunately I'll need JDK 8 on my OSX for a few more months (due to another app I'm using), so might stick with the old Terminator version for a bit more.

yeah, sadly that's probably the best idea for now. it's a bit of an unfortunate time: the old JDKs only support the eawt stuff, the new ones only support the java.awt.desktop stuff, and as long as folks are still (reasonably) on the LTS Java 8, it's even a pain to use the new stuff. (on the bright side, i did learn today that it is at least possible to get the dock menu working again --- turns out it's in a [Java 9] TaskBar class instead of the Desktop class. and they added a new API that will let us get rid of the "hidden frame" hack in Terminator so the menu bar doesn't disappear when you close the last window.)

 

I just discovered another issue with the latest Terminator build (28.130.7298) on OSX (tested with JDK 11.0.2) - When I copy some text from Safari browser, then paste does nothing in Terminator (doesn't paste anything). At the same time I can paste the same clipboard into the native OSX Terminal.app ok. Copying/pasting from Terminator to Terminator works ok, looks like only pasting stuff from other apps doesn't... I can record a video example of this if needed.

i'll try to reproduce that next time i can use a mac... i've filed https://github.com/software-jessies-org/jessies/issues/26 so i don't forget!

--
You received this message because you are subscribed to the Google Groups "terminator-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to terminator-use...@googlegroups.com.
To post to this group, send email to terminat...@googlegroups.com.
Visit this group at https://groups.google.com/group/terminator-users.
For more options, visit https://groups.google.com/d/optout.

[Elliott Hughes]

On Mon, Jan 21, 2019 at 9:58 PM Elliott Hughes <elliott....@gmail.com> wrote:

On Mon, Jan 21, 2019 at 3:57 PM Tanel Poder <ta...@poderc.com> wrote:

Thanks Elliott, comments below:

On Monday, January 21, 2019 at 1:36:46 PM UTC-5, Elliott Hughes wrote:

(i'm pretty tempted to move the publicly advertised shortcut to the tab key, since that's what Apple's Terminal uses and that's probably what 99% of folks are used to from Chrome and other browsers.)

Yep the CMD+Tab and CMD+Shift+Tab shortcuts work (I wasn't aware of their availablity).

Interestingly, Terminator 28.130.7298 shows this in the "About Terminator" window:

Normally (in previous versions) it shows the Terminator logo and version numbers.

huh. i thought i'd tested that... i'll try to get access to a Mac over the long weekend and take a look at both problems. (plus the bits of new Mac support that are known "TODO"s...)

that's working fine for me. what version of Java do you have installed?

Indeed, I did have an "old" JDK 8_u192 around (thought I had removed it ) that got used instead of JDK 11.0.2 that I also had installed. JDK 8_u192 and _u202 both show just Java 1.0 in the about box, but JDK 11.0.2 showed the correct message in that box. So it was more of a configuration problem on my side... unfortunately I'll need JDK 8 on my OSX for a few more months (due to another app I'm using), so might stick with the old Terminator version for a bit more.

yeah, sadly that's probably the best idea for now. it's a bit of an unfortunate time: the old JDKs only support the eawt stuff, the new ones only support the java.awt.desktop stuff, and as long as folks are still (reasonably) on the LTS Java 8, it's even a pain to use the new stuff. (on the bright side, i did learn today that it is at least possible to get the dock menu working again --- turns out it's in a [Java 9] TaskBar class instead of the Desktop class. and they added a new API that will let us get rid of the "hidden frame" hack in Terminator so the menu bar doesn't disappear when you close the last window.)

this weekend i've pushed (java >= 9) fixes for the dock menu and for clicking on the dock icon when there are no windows open.

still to do: the quit handlers and the copy & paste bug.

re-reading what you wrote earlier though, am i right that you're saying you had Java 8 *and* Java 11 installed, but we chose to run Java 8? if so, that's another bug we should fix...

 

 

I just discovered another issue with the latest Terminator build (28.130.7298) on OSX (tested with JDK 11.0.2) - When I copy some text from Safari browser, then paste does nothing in Terminator (doesn't paste anything). At the same time I can paste the same clipboard into the native OSX Terminal.app ok. Copying/pasting from Terminator to Terminator works ok, looks like only pasting stuff from other apps doesn't... I can record a video example of this if needed.

i'll try to reproduce that next time i can use a mac... i've filed https://github.com/software-jessies-org/jessies/issues/26 so i don't forget!

--
You received this message because you are subscribed to the Google Groups "terminator-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to terminator-use...@googlegroups.com.
To post to this group, send email to terminat...@googlegroups.com.
Visit this group at https://groups.google.com/group/terminator-users.
For more options, visit https://groups.google.com/d/optout.

--

Elliott Hughes - http://www.jessies.org/~enh/

[Elliott Hughes]

On Sat, Jan 26, 2019 at 11:28 AM Elliott Hughes <elliott....@gmail.com> wrote:

On Mon, Jan 21, 2019 at 9:58 PM Elliott Hughes <elliott....@gmail.com> wrote:

On Mon, Jan 21, 2019 at 3:57 PM Tanel Poder <ta...@poderc.com> wrote:

Thanks Elliott, comments below:

On Monday, January 21, 2019 at 1:36:46 PM UTC-5, Elliott Hughes wrote:

(i'm pretty tempted to move the publicly advertised shortcut to the tab key, since that's what Apple's Terminal uses and that's probably what 99% of folks are used to from Chrome and other browsers.)

Yep the CMD+Tab and CMD+Shift+Tab shortcuts work (I wasn't aware of their availablity).

Interestingly, Terminator 28.130.7298 shows this in the "About Terminator" window:

Normally (in previous versions) it shows the Terminator logo and version numbers.

huh. i thought i'd tested that... i'll try to get access to a Mac over the long weekend and take a look at both problems. (plus the bits of new Mac support that are known "TODO"s...)

that's working fine for me. what version of Java do you have installed?

Indeed, I did have an "old" JDK 8_u192 around (thought I had removed it ) that got used instead of JDK 11.0.2 that I also had installed. JDK 8_u192 and _u202 both show just Java 1.0 in the about box, but JDK 11.0.2 showed the correct message in that box. So it was more of a configuration problem on my side... unfortunately I'll need JDK 8 on my OSX for a few more months (due to another app I'm using), so might stick with the old Terminator version for a bit more.

yeah, sadly that's probably the best idea for now. it's a bit of an unfortunate time: the old JDKs only support the eawt stuff, the new ones only support the java.awt.desktop stuff, and as long as folks are still (reasonably) on the LTS Java 8, it's even a pain to use the new stuff. (on the bright side, i did learn today that it is at least possible to get the dock menu working again --- turns out it's in a [Java 9] TaskBar class instead of the Desktop class. and they added a new API that will let us get rid of the "hidden frame" hack in Terminator so the menu bar doesn't disappear when you close the last window.)

this weekend i've pushed (java >= 9) fixes for the dock menu and for clicking on the dock icon when there are no windows open.

still to do: the quit handlers and the copy & paste bug.

i found a bit more time and fixed the quit handlers too.

i can't reproduce the copy & paste bug though (pasting random text from wikipedia in Safari or Chrome into Terminal).

 

re-reading what you wrote earlier though, am i right that you're saying you had Java 8 *and* Java 11 installed, but we chose to run Java 8? if so, that's another bug we should fix...

 

 

I just discovered another issue with the latest Terminator build (28.130.7298) on OSX (tested with JDK 11.0.2) - When I copy some text from Safari browser, then paste does nothing in Terminator (doesn't paste anything). At the same time I can paste the same clipboard into the native OSX Terminal.app ok. Copying/pasting from Terminator to Terminator works ok, looks like only pasting stuff from other apps doesn't... I can record a video example of this if needed.

i'll try to reproduce that next time i can use a mac... i've filed https://github.com/software-jessies-org/jessies/issues/26 so i don't forget!

--
You received this message because you are subscribed to the Google Groups "terminator-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to terminator-use...@googlegroups.com.
To post to this group, send email to terminat...@googlegroups.com.
Visit this group at https://groups.google.com/group/terminator-users.
For more options, visit https://groups.google.com/d/optout.

--

Elliott Hughes - http://www.jessies.org/~enh/

--

Elliott Hughes - http://www.jessies.org/~enh/

[Tanel Poder]

On Saturday, January 26, 2019 at 2:28:39 PM UTC-5, Elliott Hughes wrote:

this weekend i've pushed (java >= 9) fixes for the dock menu and for clicking on the dock icon when there are no windows open.

still to do: the quit handlers and the copy & paste bug.

re-reading what you wrote earlier though, am i right that you're saying you had Java 8 *and* Java 11 installed, but we chose to run Java 8? if so, that's another bug we should fix...

 

It was some sort of an orphan java version (from some previous experiment I guess) that didn't go away with java uninstaller nor showed up in Homebrew installed package list. And yep for some reason JDK 8 was picked ... but I think it was an OSX/java path config problem or something as even when I ran "java -version", it showed JDK 8 I think. I can try to reproduce it.

I was unfortunately unable to build Terminator on OSX myself (got stuck in too many certificate errors), so I'll try it out whenever you've managed to upload another OSX build (no rush from me as I need to keep using the old version & Java 8 for a few months for other reasons anyway).

Thanks!

Tanel.