[TEMIR] Small Fix in TEMIR v1.1

[Ma Ho Long Perry]

Dear all,

Please kindly noted that there is a bug in PAR_absorb in the simulate_ij.R in TEMIR v1.1. The argument SAI should be SAI=SAI. I have modified it in the Dropbox and please check whether your copy contains this bug and change it accordingly. 

Best regards,
Perry

[Amos Tai]

Hi all,

First, thanks Perry for re-discovering it. This bug was indeed first discovered by David back in 2017 and fixed in v1.0. But somehow during the transition from v1.0 to v1.1, the bug was un-fixed and remained. I'm sorry about that.

Now I've fixed it again, adding notes in the Revision History as well as right above the fixed line, and already committed it to the master version on GitHub. Therefore, both the Dropbox/TGABI/TEMIR/code_v1.1 version and Github master version are fixed and consistent.

This is a serious bug indeed, contributing to an underestimation of phi_sun (slightly) and phi_sha (more seriously) which should lead to an underestimation of GPP. Perhaps the "magical" number for GPP that David has seen now is because of this unfixed bug... Please double-check your code to see if this fix is there or not. Results are only scientifically consistent if this fix is included. Hope this won't affect your major conclusions too much.

Best,

Amos

--

Amos P. K. Tai, Ph.D.

www.cuhk.edu.hk/sci/essc/tgabi/

-- 
You received this message because you are subscribed to the Google Groups "TEMIR" group.
To unsubscribe from this group and stop receiving emails from it, send an email to temir+un...@googlegroups.com.
To post to this group, send email to te...@googlegroups.com.
Visit this group at https://groups.google.com/group/temir.
To view this discussion on the web visit https://groups.google.com/d/msgid/temir/DM6PR04MB4763C4E0168748F07DCAAA9BF8FD0%40DM6PR04MB4763.namprd04.prod.outlook.com.
For more options, visit https://groups.google.com/d/optout.

[Mehliyar Sadiq]

Thank you Perry for noticing this bug. 

I have fixed this problem in my version and will rerun the simulations. Phi_sha and phi_sun affect my stomatal conductance calculations via light factor.

Regards,

Mehliyar

To view this discussion on the web visit https://groups.google.com/d/msgid/temir/8FCE49BB-6A2E-47A3-B251-A17614343700%40gmail.com.